Problem/Motivation
Part of #3582246: [meta] CLI in Core community initiative. Referenced from theCLI in Core Initiative spreadsheet.
Steps to reproduce
Try the filtering options provided in help for the command.
Try the output format options.
Proposed resolution
Allows a console user to list modules and themes by package, version, name and machine name, and installation status, and provides filtering option by name, extension type, package and installation type. Allows the user to output as a table, YAML or JSON introducing those keys in a new enum.
Remaining tasks
User interface changes
N/A
Introduced terminology
N/A
API changes
Adds a new output format enum for console output.
Data model changes
No
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3594336
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
moshe weitzman commentedI'll take this one.
Comment #4
moshe weitzman commentedA table listing modules and themes and their key properties. Also offers json and yaml as alternative output formats.
Needs review.
Comment #5
nicxvan commentedIs there a reason to not list profiles and database drivers too?
Themes and modules are the most common obviously.
Comment #6
nicxvan commentedA few questions and comments.
I could be convinced profile and database drivers should be a follow up, but I think it's probably not too much to include here.
Thanks for putting this together!
Comment #7
nicxvan commentedMoshe mentioned in slack that Drush doesn't support listing database drivers or profiles and has never had a request for it.
I think profiles might be useful, but it can be a follow up.
As for pm:info I created #3605796: Discuss creating a pm:info command
There is a CR, not sure if we want more detail on the options, but I think it's good.
Still need to manually test the options.
Comment #8
nicxvan commentedOk I manually tested:
typefor both options.formatfor both options.coreinstalledand I tested
packagewith Core and changed a module to use a test package and confirmed it works as well.Comment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #10
mradcliffeI rebased the merge request, and then filled out the issue summary.
Comment #11
nicxvan commentedI think we can make the final decision on the console line length in a follow up.
Rebase looks good.
Honestly I think 120 on a console is fine.
Comment #12
mradcliffeI'll create a follow-up shortly.
Comment #13
mradcliffeI created #3611694: Decide and implement table formatting for console command output for further discussion, standardization and implementation.
Comment #14
vidit.anjaria commented