Problem/Motivation

Remaining tasks

  1. The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-telephone. (For example, the CR for removing HAL)
  2. Tag this issue 'Needs release note.'
  3. Remove the extension ;-).
  4. Update update path tests as needed. See Learn how to write an automated update test.
  5. Remove references from core/phpstan-baseline.neon.
  6. Remove any spelling words specific to the extension from the dictionaries.
  7. Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  8. Check for references in @todo.

Release notes snippet

The telephone module has been removed from core, and can now be installed as a contrib module.

Issue fork drupal-3594199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !16140

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs review
kieran.cott’s picture

kieran.cott
Location 🇵🇭 Manila
commented

I've tested this locally,:

  1. PHP lint passes on the new fixture and changed test files.
  2. UpdatePathTestBaseFilledTest.php and PreventDowngradeTest.php pass (3 tests, exit code 0)
  3. PHPCS passes on the changed files.
  4. No stale references to core/modules/telephone, telephone/, or Drupal\telephone references outside ignored runtime/vendor areas. Any remaining “telephone” mentions are the generic tel form element/tests and the intended update fixture/tests.

+1 for RTBC.

dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs change record

This cannot be RTBC yet. There is a list of tasks to be completed in the issue summary and they have not been finished.

I edited the release note which wasn't finished.

I verified that there are no words in the CSpell dictionaries that are exclusive to the telephone module.

Tagging for a change record. The module was not added to the DRUPAL_CORE_REMOVED_MODULE_LIST constant in core/modules/system/src/Install/Requirements/SystemRequirements.php. I'm setting the status to Needs Work for these two items to be completed.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave

Thanks! Will take care of