Remove the Telephone module

I've tested this locally,:

1. PHP lint passes on the new fixture and changed test files.
2. UpdatePathTestBaseFilledTest.php and PreventDowngradeTest.php pass (3 tests, exit code 0)
3. PHPCS passes on the changed files.
4. No stale references to core/modules/telephone, telephone/, or Drupal\telephone references outside ignored runtime/vendor areas. Any remaining “telephone” mentions are the generic tel form element/tests and the intended update fixture/tests.

+1 for RTBC.

This cannot be RTBC yet. There is a list of tasks to be completed in the issue summary and they have not been finished.

I edited the release note which wasn't finished.

I verified that there are no words in the CSpell dictionaries that are exclusive to the telephone module.

Tagging for a change record. The module was not added to the DRUPAL_CORE_REMOVED_MODULE_LIST constant in core/modules/system/src/Install/Requirements/SystemRequirements.php. I'm setting the status to Needs Work for these two items to be completed.

Thanks! Will take care of

Added change record.

Struck through items completed.

"Update update path tests as needed" - didn't strike this out as not sure what I did with uninstall-telephone counts.

Should the CR title be more like the telephone module has been moved to contrib.

I think the test logic changes are appropriate. As I understand it, the objective is to make sure all update path tests continue to pass without the telephone module. But upon re-review I thought about the additional fixture. We made these kinds of fixtures for other module removals a few months ago because we had several removals to do and it would have required us to regenerate the fixture several times, not to mention regenerating it with every one that was committed. But this is the last module being removed before D12, right? Maybe we should generate a new fixture. Otherwise every update path test is going to have to include this extra fixture just like we were doing with those other fixtures earlier this year. Something else to consider: won't MRs with update paths start failing without the fixture being included? We might want to avoid having that happen again.

Alternatively, we need a follow-up to regenerate the fixture. It should probably be marked as critical to try to avoid as much issue queue chaos as possible.

Please tell me if I'm wrong.

I copied the history one but happy to update.

settings_tray, search, shortcut, olivero, and toolbar are still planned for removal

But this is the last module being removed before D12, right?

It was the last one to be decided to be removed, but it ended being one of the first ones to be ready. #3488826: [meta] Remove deprecated extensions from Drupal 12

Got it. Thank you for keeping me updated, guys.

Yeah, all the CR titles say "The {NAME} module has been removed". I don't know if it was a conscious decision to not mention the contrib move in the title.

This one looks good to me. Thank you.

Rather than the fixture to remove telephone prior to update, could we instead apply that change to the database dumps themselves and then re-export? The problem with the fixture is as we add more and more update path tests they'll all need to account for it.

But we are going to have and do this 4-5 times then. Would it be better to just do it once at the end (before D12)

settings_tray, search, shortcut, olivero, and toolbar are still in the pipeline so making the assumption they'll have the same issue.

Opened https://www.drupal.org/project/drupal/issues/3607231

With the update fixtures I dropped the telephone-uninstall script.

Committed/pushed to main, thanks!

Thanks! Published the CR

Thanks everyone! Just a FYI that the Composer name on the project page https://drupal.org/project/telephone under "Install" is not correct (drupal/telephone-telephone) and needs to get updated before too many install it ... Ensure that Telephone does not get special core treatment.