Problem/Motivation

The module's elasticsearch_connector.services.yml has few comments, inconsistent style, and doesn't seem to have an order, so it seems to make the most sense to add services at the bottom. But, adding services at the bottom increases the chance that multiple patches will conflict with each-other. Lack of whitespace also increases the chance of conflicting patches.

Proposed resolution

Order the service definitions in elasticsearch_connector.services.yml and tests/modules/elasticsearch_connector_test/elasticsearch_connector_test.services.yml alphabetically.

Add whitespace between the services, and a comment to each service.

Make the service definitions consistent style.

If tests pass, then this should not require any additional tests.

Remaining tasks

  1. Merge request 9.0.x - done by @mparker17 in #2
  2. Merge request 8.0.x - done by @mparker17 in #3
  3. Make sure tests still pass - done by @mparker17 by #5
  4. Merge 9.0.x - merged by @mparker17 in #6
  5. Merge 8.0.x - merged by @mparker17 in #8
  6. Release 9.0.x
  7. Release 8.0.x

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork elasticsearch_connector-3590887

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17 opened merge request !225

mparker17 opened merge request !226

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Created merge requests; lets see what Testbot thinks.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Great, tests pass, merging.

  • mparker17 committed 9bf738ca on 9.0.x 
    feat: #3590887 Make services.yml files more maintainable

By: mparker17
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Version: 9.0.x-dev » 8.0.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: -needs backport to 8.0.x

Awesome, merging 8.0.x

  • mparker17 committed 338b7ab4 on 8.0.x 
    feat: #3590887 Make services.yml files more maintainable

By: mparker17
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Patch (to be ported) » Fixed

Merged. I will update this issue when this change is released.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.