Problem/Motivation

The feeds_ex module currently requires:

"softcreatr/jsonpath": "^0.5 || ^0.7 || ^0.8 || ^0.9"

On PHP 8.5 upgrade attempts, Composer resolves to softcreatr/jsonpath 0.9.1, which only allows php 8.1 - 8.4. This makes feeds_ex a hard blocker for projects moving to PHP 8.5.

Steps to reproduce

composer why-not php 8.5 composer why softcreatr/jsonpath composer why-not softcreatr/jsonpath ^1.0

Observed result:

  • softcreatr/jsonpath 0.9.1 requires php (8.1 - 8.4)
  • drupal/feeds_ex constraint does not allow PHP 8.5-compatible softcreatr/jsonpath branches.

Proposed resolution

Widen the softcreatr/jsonpath version constraint in feeds_ex to include PHP 8.5-compatible releases, then validate with CI/tests on supported PHP versions including 8.5.

Example direction (maintainer to confirm final range):

"softcreatr/jsonpath": "^0.9 || ^0.10 || ^0.11 || ^1.0"

Remaining tasks

  • Update feeds_ex composer.json dependency constraint.
  • Run module test suite/CI against supported PHP matrix (including 8.5).
  • Confirm no JSONPath parser regressions.
  • Publish release containing the updated constraint.

User interface changes

None.

API changes

No functional API changes expected. Dependency constraint changes only.

Data model changes

None.

Issue fork feeds_ex-3590881

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • php8.5 Comparechanges, plain diff MR !60
  • 8.x-1.x Comparecompare
About issue forks

Comments

danieluxury created an issue. See original summary.

danieluxury’s picture

danieluxury commented
Title: Support PHP 8.5 (dependency constraint on `softcreatr/jsonpath` blocks install) » Support PHP 8.5 (dependency constraint on softcreatr/jsonpath blocks install)

ptmkenny made their first commit to this issue’s fork.

ptmkenny opened merge request !60

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

Test is failing but I'm pretty sure it's broken in the main branch and not related to this.

megachriz made their first commit to this issue’s fork.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

All tests are passing with softcreatr/jsonpath 1.0.2 on PHP 8.5, so I scheduled the merge! Thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • megachriz committed 89417552 on 8.x-1.x authored by ptmkenny 
    task: #3590881 Added support for PHP 8.5 and softcreatr/jsonpath 1.0.x...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.