Problem/Motivation

SiteAuditRemoveApiResource uses a bunch of direct calls to Drupal services which should be injected with DI. Let's do that.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3588354-1.patch3.4 KBsahana _n

Issue fork site_audit_server-3588354

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

froboy created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Assigned: Unassigned » sahana _n
froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
Assigned: sahana _n » Unassigned

@sahana_n please do not assign issues to yourself without making a comment about what you are doing. Please review the Drupal.org guidelines on assigning issues.

sahana _n’s picture

sahana _n commented
StatusFileSize
new 3588354-1.patch3.4 KB

I created the patch. Please review.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review

froboy opened merge request !3

  • ad29080f committed on 4.x 
    [#3588354] Clean up dependency injection
froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
Status: Needs review » Fixed

@sahana _n thank you for your work. A few tips:

Patch files are no longer recommended, use merge requests instead.

Please review your work with PHPCS before committing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.