Problem/Motivation

The $this->settings->get('file_public_path') is not always there.

This causes all the css and js routes to be redirected to the agreement page, which breaks page design.

Steps to reproduce

Proposed resolution

Use the PublicStream::basePath as a fallback when file_public_path is not defined.

Remaining tasks

-

CommentFileSizeAuthor
#2 fix-public-path-3587409-2.patch1022 bytesnagy.balint

Issue fork agreement-3587409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nagy.balint created an issue. See original summary.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs review
StatusFileSize
new fix-public-path-3587409-2.patch1022 bytes

Here is a patch for the issue.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Needs work

Thank you for the report, and the patch, @nagy.balint! I appreciate it.

Can you create a merge request for the patch if you have the time? I set the status to Needs work, but I think the changes probably seem good enough.

I added the issue summary template to the issue summary.

nagy.balint opened merge request !24

nagy.balint’s picture

nagy.balint commented
Status: Needs work » Needs review

I changed it to simply use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21StreamWra...
since that already uses Settings::get('file_public_path'

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Thank you again. I reviewed and then set the merge request to auto-merge.

I will probably tag a new release sometime within the next week or two.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.