Problem/Motivation

If a link is followed by a , then this is included in the link, breaking it.
Links followed by a . work correctly.

Steps to reproduce

Test a module where no default theme is defined.

Proposed resolution

Change the regex to also make links with a , clickable.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
upgrade-status-comment.png19.89 KBifrik

Issue fork upgrade_status-3586837

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ifrik created an issue. See original summary.

ifrik’s picture

ifrik
she/her
commented
Issue summary: View changes

ifrik opened merge request !127

ifrik’s picture

ifrik
she/her
commented
Status: Active » Needs review

ifrik changed the visibility of the branch 3586837-links-break-if to hidden.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks great. We discussed this also in person at devdays.

  • gábor hojtsy committed b216227e on 5.x authored by ifrik 
    feat: #3586837 Links break if follow by a comma

By: ifrik
By: gábor...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.