Closed (fixed)
Project:
Drupal core
Version:
main
Component:
search.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Apr 2026 at 09:09 UTC
Updated:
16 Oct 2026 at 12:40 UTC
Jump to comment: Most recent
Postponed on #3595089: Remove the Olivero theme and may need a rebase when that is committed.
core/phpstan-baseline.neon.The Search module has been removed from core, and can now be installed as a contrib module,
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
catchI think this is unblocked now, but it needs a rebase.
Comment #5
gábor hojtsyRebased. Prior fails included stuff in Olivero, do we have a removal order we are going in? If Olivero is removed before this then we don't need to remove search stuff from Olivero.
Also the core_fake database driver still has SearchQuery and ViewsSearchQuery references even with this MR I think.
Comment #6
catchIt looks like we're three issues away from Olivero removal, #3622600: Remove remaining uses of Olivero in tests, the issue to deprecate, and the issue to actually remove, so trying to get those done first to reduce the work here probably makes sense - although the maintenance burden of search is higher than Olivero in general.
Didn't check those but I think we could delete them here too?
Comment #7
gábor hojtsyRemaining failures all seem to be down to Olivero, so postponing then on removing Olviero: #3595089: Remove the Olivero theme.
Comment #8
quietone commentedComment #9
quietone commentedComment #10
quietone commentedBy following step 8 I found uses in SchemaCheckTrait.php which I removed.
Comment #11
catchReviewed everything that was not within the search module directory that we're removing entirely. Can't see anything to complain about.
Comment #12
godotislateThis removal from SchemaCheckTrait mentions #3380475: SearchPage entities implicitly require labels: make explicit, and fix migration from D7:
The reference to
search.settingsin that issue probably needs to be split out to its own issue in the contrib search queue.Otherwise this looks good, and I can commit later when I'm back at the computer. I'll also re-verify then whether there aren't any search references left to remove after applying the changes.
Comment #14
larowlanCommitted and pushed 64a266aae44 to main. Thanks!
I did grep for search after removing but there's so many references in things like $search in str_replace that I'm sure we will find tendrils in the future.
Great work all.
Comment #16
godotislateI quoted the wrong snippet in #12. I meant this one:
The reference to
search.settingsis in #3425992: contact.settings, filter.settings, etc. all have dependencies, which violates the basic rule of simple config.I have created the new issue for Search: #3624588: search.settings has dependencies, which violates the basic rule of simple config.
Comment #17
mlncn commentedJust want to note that there was surely (surely?) discussion about the decision to remove Search module from core, but nothing is reflected here. It feels weird to have task-only issues, with no reference to the context of why the task was undertaken, for major things like moving a core module to contrib! I think it would be best practice to link to, or paste into a background section of the module section, some reference to the motivation. (I think i can guess and i agree, but again— strange not to have any reference available from here.)
Comment #18
larowlan@mlncn #3476883: [Policy, no patch] Move Search module to contrib is linked from the issue summary of the parent
Added as a related link here.
Comment #19
quietone commentedIn this case, there are quite a lot of steps involved in Deprecating and Removing an extension that it is not practical to link to the policy issue on every task. So, we put it in both the meta for the deprecation tasks and the meta for the removal tasks. And this is documented in the How to deprecate and remove an extension. That provides templates to use to create these metas which includes linking to the policy issue.
Comment #20
gábor hojtsyThis turned up while writing Drupal 12 beta release notes: #3627629: Remove search module coverage from robots.txt.