Problem/Motivation

Remaining tasks

Postponed on #3595089: Remove the Olivero theme and may need a rebase when that is committed.

  1. The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-search. (For example, the CR for removing HAL)
  2. Tag this issue 'Needs release note.'
  3. Remove the extension ;-).
  4. Update update path tests as needed. See Learn how to write an automated update test.
  5. Remove references from core/phpstan-baseline.neon.
  6. Remove any spelling words specific to the extension from the dictionaries.
  7. Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  8. Check for references in @todo.

Release notes snippet

The Search module has been removed from core, and can now be installed as a contrib module,

Issue fork drupal-3586217

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

catch’s picture

Status: Postponed » Needs work

I think this is unblocked now, but it needs a rebase.

gábor hojtsy made their first commit to this issue’s fork.

gábor hojtsy’s picture

Rebased. Prior fails included stuff in Olivero, do we have a removal order we are going in? If Olivero is removed before this then we don't need to remove search stuff from Olivero.

Also the core_fake database driver still has SearchQuery and ViewsSearchQuery references even with this MR I think.

catch’s picture

It looks like we're three issues away from Olivero removal, #3622600: Remove remaining uses of Olivero in tests, the issue to deprecate, and the issue to actually remove, so trying to get those done first to reduce the work here probably makes sense - although the maintenance burden of search is higher than Olivero in general.

Also the core_fake database driver still has SearchQuery and ViewsSearchQuery references even with this MR I think.

Didn't check those but I think we could delete them here too?

gábor hojtsy’s picture

Status: Needs work » Postponed

Remaining failures all seem to be down to Olivero, so postponing then on removing Olviero: #3595089: Remove the Olivero theme.

quietone’s picture

Issue summary: View changes
quietone’s picture

Status: Postponed » Needs review
quietone’s picture

By following step 8 I found uses in SchemaCheckTrait.php which I removed.

catch’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed everything that was not within the search module directory that we're removing entirely. Can't see anything to complain about.

godotislate’s picture

This removal from SchemaCheckTrait mentions #3380475: SearchPage entities implicitly require labels: make explicit, and fix migration from D7:

    'search.page.*' => [
      // @todo Fix config or tweak schema of `type: search.page.*` in
      //   https://drupal.org/i/3380475.
      // @see search.schema.yml
      'label' => [
        'This value should not be blank.',
      ],
    ],

The reference to search.settings in that issue probably needs to be split out to its own issue in the contrib search queue.

Otherwise this looks good, and I can commit later when I'm back at the computer. I'll also re-verify then whether there aren't any search references left to remove after applying the changes.

  • larowlan committed 64a266aa on main
    task: #3586217 Remove the Search module
    
    By: quietone
    By: catch
    By:...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 64a266aae44 to main. Thanks!

I did grep for search after removing but there's so many references in things like $search in str_replace that I'm sure we will find tendrils in the future.

Great work all.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

godotislate’s picture

I quoted the wrong snippet in #12. I meant this one:

'search.settings' => [
      // @todo Simple config cannot have dependencies on any other config.
      //   Remove this in https://www.drupal.org/project/drupal/issues/3425992.
      'default_page' => [
        "The 'search.page.node_search' config does not exist.",
      ],
    ],

The reference to search.settings is in #3425992: contact.settings, filter.settings, etc. all have dependencies, which violates the basic rule of simple config.

I have created the new issue for Search: #3624588: search.settings has dependencies, which violates the basic rule of simple config.

mlncn’s picture

Just want to note that there was surely (surely?) discussion about the decision to remove Search module from core, but nothing is reflected here. It feels weird to have task-only issues, with no reference to the context of why the task was undertaken, for major things like moving a core module to contrib! I think it would be best practice to link to, or paste into a background section of the module section, some reference to the motivation. (I think i can guess and i agree, but again— strange not to have any reference available from here.)

larowlan’s picture

@mlncn #3476883: [Policy, no patch] Move Search module to contrib is linked from the issue summary of the parent

Added as a related link here.

quietone’s picture

In this case, there are quite a lot of steps involved in Deprecating and Removing an extension that it is not practical to link to the policy issue on every task. So, we put it in both the meta for the deprecation tasks and the meta for the removal tasks. And this is documented in the How to deprecate and remove an extension. That provides templates to use to create these metas which includes linking to the policy issue.

gábor hojtsy’s picture

This turned up while writing Drupal 12 beta release notes: #3627629: Remove search module coverage from robots.txt.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.