Problem/Motivation

In order for Drupal.t() to function, Drupal must be able to parse the built JS file that is attached to identify strings that need to be translated. This means `Drupal.t` can't be passed as a callback, as is done in the slideshow js and `Drupal.t` can't be mangled by Uglify for production builds.

Proposed resolution

1. Refactor slideshow JS to translate strings directly with Drupal.t rather than via a callback
2. Configure uglify to preserve Drupal.t when compressing JS

Issue fork prototype-3585336

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pixelwhip created an issue. See original summary.

jldust made their first commit to this issue’s fork.

jldust opened merge request !234

jldust’s picture

jldust commented
Status: Active » Needs review
jldust’s picture

jldust commented
Status: Needs review » Fixed

This has been merged in and will be included in the next tagged release.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.