Problem/Motivation

Search is being deprecated, see the parent issue for details. This issue is for removing Search from the nightwatch_a11y_testing profile & a11y tests.

Though Nightwatch is also being deprecated, I presume the profile will be used under a different name for #3338664: Migrate Nightwatch Axe tests to PHPUnit.

Steps to reproduce

Proposed resolution

  1. As was done for the standard profile, remove the lines containing search in:
    • core/profiles/tests/nightwatch_a11y_testing/nightwatch_a11y_testing.info.yml
    • core/profiles/tests/nightwatch_a11y_testing/config/install/user.role.anonymous.yml
  2. Remove the test case that contains path: '/search/node' in core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js, as well as the two comment lines immediately before that test case.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3584694

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

quietone’s picture

quietone commented
Parent issue: #3567672: Remove Search module from Standard, Umami and recipes » #3565780: [meta] Tasks to deprecate the Search module
quietone’s picture

quietone commented
Version: 11.x-dev » main
kentr’s picture

kentr commented
Issue summary: View changes

@quietone thanks for correcting the metadata.

This might be one for a first-time contributor.

kentr’s picture

kentr commented
Issue summary: View changes
ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel

ishani patel opened merge request !15531

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned

Hello,
I've raised MR.
Kindly review it.

Thank you!

quietone’s picture

quietone commented
Status: Active » Needs work

@kentr, any tips on how to fix these errors?

quietone’s picture

quietone commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3318398: Address A11y test fails in search/node

I used the following grep commands to try and locate any other references to the Search module within the profile and test:

~/drupal_core$ grep -ri "search" core/profiles/tests/nightwatch_a11y_testing/
~/drupal_core$ grep -ri "search" core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js

No instances of the string "search" were found in either case. It seems like this is probably all we need to remove.

The changes are simple. I have no real feedback to give about them. They look good to me.

I'm adding a related issue that was postponed on this one. It needs to be updated and repurposed or possibly closed after this issue is fixed.

kentr’s picture

kentr commented

Adding to #11 for the record:

There are other Nightwatch a11y tests. I searched them previously and double-checked just now, with the following command:

find core -iname *a11y*.js | xargs grep -i search

The only file in the results is core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js (in main, without the MR).

  • amateescu committed e26dc2ac on 11.x 
    task: #3584694 Remove Search module from nightwatch_a11y_testing profile...

  • amateescu committed db370520 on main 
    task: #3584694 Remove Search module from nightwatch_a11y_testing profile...
amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed db37052 to main and e26dc2a to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15531

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.