Problem/Motivation

In #3582599: [4.x] Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) we found out that 3.x isn't "really" ^11 compatible due to https://www.drupal.org/project/drupal/issues/3239012

So we should remove ^11 compatibility from 3.x and tag a release so CI should be fine for 3.x also and ^11 should use 4.x.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_mentions-3582821

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !52

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Remove ^11 compatibility from 3.x » Remove ^11 compatibility from 3.x once we have a 4.0.0 stable release
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3582825: [4.x] Remove the CkEditor4to5 Upgrade Plugin

anybody opened merge request !54

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs work » Needs review

Mhm unsure why phpunit is failing with Drupal ^10.3?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

phpunit tries running with Drupal installed version: 11.3.5.

Is that a global thing? I always though previous major etc. is relative to the modules Drupal Core version, but maybe not and we need to test with previous major?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Nope the last commit and thoughts in #9 don't seem to help

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

grevil changed the visibility of the branch 3582821-4.x-d11-compat to hidden.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Reviewed & tested by the community

No idea, php unit previous major is still being skipped for whatever reason, so we can revert this change again and use the better opt out current version.

Let's merge this. It won't get better and we should focus on 4.x

  • grevil committed 35473e1e on 3.0.x authored by anybody 
    feat: #3582821 Remove ^11 compatibility from 3.x
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.