Problem/Motivation

Part of deprecating Claro

Steps to reproduce

Proposed resolution

This focuses on Functional and FunctionalJavascript tests in core/modules

Most tests here replace Claro with Default Admin. The exceptions are:

  • core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php
  • core/modules/block_content/tests/src/Functional/BlockContentTypeTest.php
  • core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php - AI assisted solution
  • core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php - removes Claro
  • core/modules/toolbar/tests/src/Functional/ToolbarClaroOverridesTest.php - can stay in module as it should be deprecated before Claro

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#22 3582153-nr-bot_ym31kkty.txt91 bytesneeds-review-queue-bot
#13 3582153-nr-bot_g4t2vtzp.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3582153

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15273

quietone’s picture

quietone commented
Title: Update Functional tests that use Claro to Admin » Update Functional tests in modules that use Claro to Admin
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs work

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented

Fixed 3 tests.

Disclosure used AI to help fix the breadcrumb one as for the life of me could not.

Left a comment on the Toolbar test failure about reverting back.

The last failure would require us to update the test fixtures again.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review

Tests are passing and the proposed resolution is updated.

godotislate’s picture

godotislate
he/him
commented

1 question on the MR.

Also, does core/modules/toolbar/tests/src/Functional/ToolbarClaroOverridesTest.php need to be cited in the IS as an exception?

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

OK, lgtm

smustgrave’s picture

smustgrave commented

May even want to consider removing that snippet of a test if default_admin is going to be the only theme shipped?

quietone’s picture

quietone commented
Issue summary: View changes

  • catch committed e8208641 on main 
    task: #3582153 Update Functional tests in modules that use Claro to...
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3582153-nr-bot_g4t2vtzp.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Needs work » Patch (to be ported)

Some of the test coverage looks a bit questionable, but that's long before this issue and we're only updating it here. It might be worth a follow-up to e.g. change menubreadcrumbtest to only use stark.

Committed/pushed to main, thanks!

Moving to 11.x for backport.

smustgrave opened merge request !17119

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Needs review

All green backport.

smustgrave’s picture

smustgrave commented
Status: Needs review » Patch (to be ported)

Actually looking into failure.

smustgrave’s picture

smustgrave commented

This one seems to be blocked on #3617584: Change tests using Olivero which is also being backported.

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Needs review

Should be postponed but merged in #3617584: Change tests using Olivero which fixes the random failures here. But this can still be reviewed as that one is RTBC for it's backport.

godotislate’s picture

godotislate
he/him
commented

It looks like the changes in the main commit are in the MR correctly, but because of all the changes currently in from #3617584: Change tests using Olivero, the rest is a bit hard to parse. Will need another look after that issue is in and this is rebased.

smustgrave’s picture

smustgrave commented

I wanted to be sure the failures were covered. But correct that will have to land first but since it’s RTBC I’m hopeful

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3582153-nr-bot_ym31kkty.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Rebase with quite a few conflicts so setting to NR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

With olivero landing this seems like a good backport

  • godotislate committed 060cbbb2 on 11.x 
    task: #3582153 Update Functional tests in modules that use Claro to...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed 060cbbb and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.