Problem/Motivation

After after apply the diffs in the child issues the word 'olivero' is found in 38 tests.

$ git grep -lwi olivero | grep -v core/themes/olivero/ | grep -v core/assets | grep -v phpstan-baseline | grep -v MAINTAINERS | grep -v core/.cspell.json | grep -v core/misc/cspell/drupal-dictionary | grep -v core/modules/shortcut | grep -v core/modules/search | grep -i test | grep -v core/tests/README.md | wc -l
37

Steps to reproduce

Proposed resolution

Use a test theme

  • core/modules/block/tests/src/Functional/BlockAdminThemeTest.php
  • core/modules/block/tests/src/Functional/NonDefaultBlockAdminTest.php

Replace with 'claro'

  • core/modules/block/tests/src/FunctionalJavascript/BlockDragTest.php
  • core/modules/system/tests/src/Functional/Condition/ConditionFormTest.php
  • core/modules/system/tests/src/Kernel/Theme/TwigNamespaceTest.php

Replace with 'my_theme'

  • core/modules/filter/tests/src/Kernel/FilterKernelTest.php

Replace with 'stark'

  • core/modules/block/tests/src/Kernel/ConfigActionsTest.php
  • core/modules/breakpoint/tests/src/Kernel/BreakpointDiscoveryTest.php
  • core/modules/breakpoint/tests/themes/breakpoint_theme_test/breakpoint_theme_test.info.yml
  • core/modules/image/tests/src/Kernel/ImageThemeFunctionTest.php
  • core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php
  • core/modules/system/tests/modules/image_lazy_load_test/src/Controller/ImageLazyLoadController.php
  • core/modules/system/tests/src/Functional/Batch/PageTest.php
  • core/modules/taxonomy/tests/src/Functional/ThemeTest.php
  • core/tests/Drupal/BuildTests/Command/GenerateThemeTest.php

Remove 'olivero'

  • core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php

Remaining tasks

For each test, either move the test, or the parts specific to Olivero to Olivero, or change the use of Olivero so it can be deprecated.

  1. core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php
  2. core/modules/config/tests/src/Functional/ConfigImportUITest.php
  3. core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php
  4. core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php
  5. core/modules/package_manager/tests/src/Kernel/StagedDBUpdateValidatorTest.php
  6. core/modules/system/tests/src/Functional/Entity/EntityComputedFieldTest.php
  7. core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php
  8. core/modules/system/tests/src/Functional/System/ThemeTest.php
  9. core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
  10. core/modules/views/tests/src/Kernel/Handler/AreaOrderTest.php
  11. core/profiles/tests/nightwatch_a11y_testing/config/install/system.theme.yml
  12. core/profiles/tests/nightwatch_a11y_testing/nightwatch_a11y_testing.info.yml
  13. core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js
  14. core/tests/Drupal/TestSite/HtmxAssetLoadTestSetup.php
  15. core/tests/Drupal/Tests/WebAssert.php

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3617584

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes

$ git grep -lwi olivero | grep -v core/themes/olivero/ | grep -v core/assets | grep -v phpstan-baseline | grep -v MAINTAINERS | grep -v core/.cspell.json | grep -v core/misc/cspell/drupal-dictionary | grep -v core/modules/shortcut | grep -v core/modules/search | grep -i test | grep -v core/tests/README.md | nl
1 core/modules/block/tests/src/Functional/BlockAdminThemeTest.php
2 core/modules/block/tests/src/Functional/NonDefaultBlockAdminTest.php
3 core/modules/block/tests/src/FunctionalJavascript/BlockDragTest.php
4 core/modules/block/tests/src/Kernel/ConfigActionsTest.php
5 core/modules/breakpoint/tests/src/Kernel/BreakpointDiscoveryTest.php
6 core/modules/breakpoint/tests/themes/breakpoint_theme_test/breakpoint_theme_test.info.yml
7 core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php
8 core/modules/comment/tests/src/Functional/CommentPreviewTest.php
9 core/modules/config/tests/src/Functional/ConfigImportUITest.php
10 core/modules/filter/tests/src/Kernel/FilterKernelTest.php
11 core/modules/image/tests/src/Kernel/ImageThemeFunctionTest.php
12 core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php
13 core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php
14 core/modules/package_manager/tests/src/Kernel/StagedDBUpdateValidatorTest.php
15 core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php
16 core/modules/system/tests/modules/image_lazy_load_test/src/Controller/ImageLazyLoadController.php
17 core/modules/system/tests/modules/olivero_test/config/optional/block.block.olivero_secondary_local_tasks.yml
18 core/modules/system/tests/modules/olivero_test/olivero_test.info.yml
19 core/modules/system/tests/src/Functional/Batch/PageTest.php
20 core/modules/system/tests/src/Functional/Condition/ConditionFormTest.php
21 core/modules/system/tests/src/Functional/Entity/EntityComputedFieldTest.php
22 core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php
23 core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php
24 core/modules/system/tests/src/Functional/System/ThemeTest.php
25 core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
26 core/modules/system/tests/src/Kernel/Theme/TwigNamespaceTest.php
27 core/modules/taxonomy/tests/src/Functional/ThemeTest.php
28 core/modules/views/tests/src/Kernel/Handler/AreaOrderTest.php
29 core/profiles/tests/nightwatch_a11y_testing/config/install/system.theme.yml
30 core/profiles/tests/nightwatch_a11y_testing/nightwatch_a11y_testing.info.yml
31 core/tests/Drupal/BuildTests/Command/GenerateThemeTest.php
32 core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php
33 core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js
34 core/tests/Drupal/TestSite/HtmxAssetLoadTestSetup.php
35 core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php
36 core/tests/Drupal/TestSite/TestSiteOliveroInstallTestScript.php
37 core/tests/Drupal/Tests/WebAssert.php

quietone’s picture

Issue summary: View changes
Status: Active » Needs work
quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes

These use the 'olivero_test' module so changing those is worth a separate issue.

core/modules/comment/tests/src/Functional/CommentPreviewTest.php
core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php
core/modules/system/tests/modules/olivero_test/olivero_test.links.menu.yml
core/modules/system/tests/modules/olivero_test/src/Hook/OliveroTestThemeHooks.php
core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php
core/tests/Drupal/FunctionalTests/Theme/OliveroTest.php
core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php
core/tests/Drupal/TestSite/TestSiteOliveroInstallTestScript.php

Move to #3618256: Adjust tests using olivero_test test module

quietone’s picture

Issue summary: View changes