Convert Unit and Kernel tests that use Claro to Admin [#3582093]

Problem/Motivation

Steps to reproduce

Proposed resolution

Adjust tests as needed but comment only is done in a separate issue

core/modules/user/tests/src/Unit/Theme/AdminNegotiatorTest.php
core/modules/block/tests/src/Kernel/ConfigActionsTest.php
core/modules/contextual/tests/src/Kernel/ContextualUnitTest.php
core/modules/help/tests/src/Kernel/HelpTopicsSyntaxTest.php
core/modules/system/tests/src/Kernel/Theme/TwigNamespaceTest.php
core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php
core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
core/tests/Drupal/KernelTests/Core/Recipe/EntityMethodConfigActionsTest.php
core/tests/Drupal/KernelTests/Core/Recipe/RecipeValidationTest.php
core/tests/Drupal/KernelTests/Core/StreamWrapper/ExtensionStreamTest.php
core/tests/Drupal/KernelTests/Core/Theme/ClaroVerticalTabsTest.php
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php
core/tests/Drupal/Tests/Core/Extension/ModuleRequiredByThemesUninstallValidatorTest.php
core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php
core/tests/Drupal/Tests/Core/Theme/CoreThemesAutoloadedForTestsTest.php

Other

core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php - this is a comment only and will be fixed in the sibling issue for comments
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php - do in Default Admin #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#25	3582093-nr-bot_yjg4j5k5.txt	91 bytes	needs-review-queue-bot

Issue fork drupal-3582093

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3 hidden branches

3582093-backport

changes, plain diff MR !17133

Check out this branch for the first time

Check out existing branch, if you already have it locally

3582093-mets-convert-tests

changes, plain diff MR !15266

Check out this branch for the first time

Check out existing branch, if you already have it locally

main

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

29 March 2026 at 08:48

quietone created an issue. See original summary.

Comment #2

quietone commented 29 March 2026 at 09:26

Title:

[mets] Convert tests that use Claro to Admin

» Convert Unit and Kernel tests that use Claro to Admin

Comment #3

29 March 2026 at 09:41

quietone opened merge request !15266

Comment #4

quietone commented 9 September 2026 at 09:02

Status:

Active

» Needs work

There are failures in two files. How to fix these?

Drupal\KernelTests\Core\Theme\AdminVerticalTabsTest::testVerticalTabs
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "user_role" entity type does not exist.

Why is a change of theme causing the user_role not to exist?

and

Drupal\KernelTests\Core\Asset\ResolvedLibraryDefinitionsFilesMatchTest::testCoreLibraryCompleteness
public://admin-custom.css file referenced from the default_admin/admin_custom_css library does not exist.
Failed asserting that file "public://admin-custom.css" exists.

Admin theme has this in its .libraries.yml, and of course that won't exist. Can that be deleted or does it need to be moved or .. ?

# Custom CSS

admin_custom_css:
  css:
    theme:
      public://admin-custom.css: { preprocess: false, minified: false, weight: 50 }

Comment #5

catch

he/him

English

commented 9 September 2026 at 09:19

Let's open a new issue about admin_custom_css - that looks like a Gin feature that we should not try to support in core at all, so I think we should remove the library altogether.

User role not existing, would need to debug the test probably.

Comment #6

9 September 2026 at 09:33

daffie made their first commit to this issue’s fork.

Comment #7

daffie commented 9 September 2026 at 09:34

Disclosure: I used AI to fix the failing tests.

Comment #8

daffie commented 9 September 2026 at 09:44

Status:

Needs work

» Needs review

The Gitlab CI pipeline is now green.

Comment #9

quietone commented 9 September 2026 at 11:28

Issue made for #5, #3621981: Remove admin-custom.css

Comment #11

quietone commented 10 September 2026 at 09:35

Status:

Postponed

» Needs review

Comment #12

quietone commented 10 September 2026 at 09:40

Issue summary:

View changes

Comment #13

dcam commented 10 September 2026 at 17:10

Status:

Needs review

» Needs work

Setting to Needs Work for a rebase and the ResolvedLibraryDefinitionsFilesMatchTest change to be reverted.

Comment #14

quietone commented 11 September 2026 at 12:57

I made the change to ResolvedLibraryDefinitionsFilesMatchTest.

Unfortunately, I have run into a problem with generating the baseline. As you will be the commits, I tried a few times hoping to figure out why what I have done locally no longer works. I haven't found out why this is happening. And with GitLab being slow and this issue not getting updated. I give up for now.

Maybe someone else will have better luck.

Comment #15

quietone commented 11 September 2026 at 14:12

Status:

Needs work

» Needs review

OK, my problems were caused by the update of PHPStan, which has been reverted and a copy/paste error on my part that I just kept not seeing. The important thing is that tests are passing.

Comment #16

dcam commented 11 September 2026 at 14:58

There are several test classes that still reference Claro found via grep and also listed in the issue summary, including the following:

core/modules/help/tests/src/Kernel/HelpTopicsSyntaxTest.php
core/modules/system/tests/src/Kernel/Theme/TwigNamespaceTest.php
core/tests/Drupal/Tests/Core/Extension/ModuleRequiredByThemesUninstallValidatorTest.php
core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php
core/tests/Drupal/Tests/Core/Theme/CoreThemesAutoloadedForTestsTest.php
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php

Were these omitted intentionally? If so I just want to make sure it's documented. There are a few classes where it looks like the reference to Claro doesn't matter much, but there are others where it seems like the reference needs to be changed.

Comment #17

12 September 2026 at 06:38

quietone changed the visibility of the branch main to hidden.

Comment #18

quietone commented 12 September 2026 at 10:16

Issue summary:

View changes

@dcam, thanks. I have been a bit behind on getting the issue summaries on these up to date.

I've updated the issue summary from the results in #16

Comment #19

quietone commented 12 September 2026 at 10:34

Issue summary:	View changes
Status:	Needs review	» Needs work

Comment #20

quietone commented 12 September 2026 at 12:00

Issue summary:

View changes

Comment #21

quietone commented 12 September 2026 at 12:16

This might be postponed on #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme.

Comment #22

quietone commented 13 September 2026 at 21:35

Issue summary:	View changes
Status:	Needs work	» Needs review

Actually ImplementationNameTest.php needs fixes over in #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme, so setting this to needs reveiew

Comment #23

quietone commented 13 September 2026 at 21:35

Issue summary:

View changes

Comment #24

daffie commented 14 September 2026 at 09:40

Status:

Needs review

» Reviewed & tested by the community

All code changes look good to me.
All remarks on the PR are answered.
For me it is RTBC.

Comment #25

needs-review-queue-bot commented 14 September 2026 at 09:44

Status:

Reviewed & tested by the community

» Needs work

Status	File	Size
new	3582093-nr-bot_yjg4j5k5.txt	91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Comment #26

catch

he/him

English

commented 14 September 2026 at 09:52

Needs a rebase.

Comment #27

quietone commented 14 September 2026 at 14:11

Status:

Needs work

» Reviewed & tested by the community

Straightforward rebase

Comment #28

14 September 2026 at 15:40

catch committed aa94eca6 on main

task: #3582093 Convert Unit and Kernel tests that use Claro to Admin

By...

Comment #29

catch

he/him

English

commented 14 September 2026 at 15:41

Version:	main	» 11.x-dev
Status:	Reviewed & tested by the community	» Patch (to be ported)

Committed/pushed to main, thanks!

Moving to 11.x for backport.

Patch (to be ported)

» Reviewed & tested by the community

Backport is all green.

Comment #33

mstrelan commented 16 September 2026 at 01:12

Reviewed the main commit and the backport side by side and they appear identical, RTBC +1.

Comment #34

16 September 2026 at 07:08

catch committed 4a987462 on 11.x

task: #3582093 Convert Unit and Kernel tests that use Claro to Admin

By...

Comment #35

catch

he/him

English

commented 16 September 2026 at 07:09

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 11.x, thanks!

Comment #36

16 September 2026 at 07:09

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Comment #37

30 September 2026 at 07:10

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Convert Unit and Kernel tests that use Claro to Admin

Problem/Motivation

Steps to reproduce

Proposed resolution

Other

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582093

Comments

Parent issue