Problem/Motivation

There is support for the Book module.

$ git grep -liw book core/themes/default_admin 
core/themes/default_admin/templates/classy/content/book-node-export-html.html.twig
core/themes/default_admin/templates/classy/layout/book-export-html.html.twig
core/themes/default_admin/templates/classy/navigation/book-all-books-block.html.twig
core/themes/default_admin/templates/classy/navigation/book-navigation.html.twig
core/themes/default_admin/templates/classy/navigation/book-tree.html.twig

Found while searching a.d.o for references to extensions that have been removed because of an old bug on that site.

Steps to reproduce

Proposed resolution

TBA

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3581831

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15232

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

I am not sure if removing these is correct.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

I believe removing is correct since this admin_theme won't be in a major version of core that should still have book.

As the book maintainer in contrib I did open #3581919: Look to see if any templates need to be brought over for admin_theme to see if there's anything we should bring over.

smustgrave’s picture

smustgrave commented

And looking at one of them classy.book-navigation is a library that doesn't exist.

quietone’s picture

quietone commented
Title: Remove support for books » Remove support for Book Module
quietone’s picture

quietone commented
Title: Remove support for Book Module » Remove support for Book and Fourm Module
Status: Reviewed & tested by the community » Needs review

And for Forum as well.

$ git grep -iwl forum core/themes/default_admin 
core/themes/default_admin/templates/classy/dataset/forum-icon.html.twig
core/themes/default_admin/templates/classy/dataset/forum-list.html.twig
core/themes/default_admin/templates/classy/dataset/forums.html.twig
core/themes/default_admin/templates/classy/user/forum-submitted.html.twig
quietone’s picture

quietone commented

There is also 'contact'. Is this for the contact module?

$ git grep -iw contact core/themes/default_admin 
core/themes/default_admin/css/components/jquery.ui/theme.css:.ui-icon-contact {
core/themes/default_admin/css/components/jquery.ui/theme.pcss.css:.ui-icon-contact {
smustgrave’s picture

smustgrave commented

not in front of my computer should we check every deprecated module in 10 + 11

quietone’s picture

quietone commented

I did see my comment in the parent, https://www.drupal.org/project/drupal/issues/3576488#comment-16529666

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: Remove support for Book and Fourm Module » Remove support for Book and Forum Module
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks for already doing that @quietone.

I opened #3582049: Potential templates for new admin_theme for the forum module. This looks good to go.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15232

  • catch committed 42fa99f4 on 11.x 
    task: #3581831 Remove support for Book and Forum Module

By: quietone
By...

  • catch committed 24542849 on main 
    task: #3581831 Remove support for Book and Forum Module

By: quietone
By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.