Problem/Motivation

Not all fields are supported by CivicTheme in which case these fields are passed back to Drupal to find an appropriate template.

But in these cases it would be good if we still used the civictheme label component which will provide civictheme styles for labels.

Proposed resolution

1. Hook up civictheme:label component with the label template provided by Drupal. This will be used only on fields not supported by CivicTheme

Comments

richardgaunt created an issue. See original summary.

richardgaunt’s picture

richardgaunt commented
Assigned: richardgaunt » alan.cole

@alan https://github.com/civictheme/monorepo-drupal/pull/1502 - PR for your review.

richardgaunt’s picture

richardgaunt commented
Status: Active » Needs review

@alan https://github.com/civictheme/monorepo-drupal/pull/1502 - for your review

richardgaunt’s picture

richardgaunt commented
Assigned: alan.cole » danielgry

@danielgry Please go to the test webform, more exotic form elements should now be using `

  • c2ba6e95 committed on 1.x 
    [#3581084] Added fallback label template to map to civictheme:label...
richardgaunt’s picture

richardgaunt commented
Status: Needs review » Reviewed & tested by the community
richardgaunt’s picture

richardgaunt commented
Version: 1.x-dev » 1.13.0
Assigned: danielgry » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.