In the README file, the sentence:

"providing a fast and full access to all administration links."

can be improved by removing the unnecessary article "a" for better grammar.

Suggested fix:
"providing fast and full access to all administration links."

Comments

sai gautam created an issue. See original summary.

sai gautam’s picture

Here is a patch to improve the wording in the README file.

ressa’s picture

Version: 3.6.3 » 3.x-dev

Please don't spam the issue queue with such small, and maybe even unnecessary changes, I'll close the other ones.

If you want to improve the README:

  1. Share all small suggestions in a single issue (could be this one)
  2. Create an MR: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

Patch files are no longer used.

dydave’s picture

Thanks a lot @ressa, as always, for keeping an eye on the module and sifting throught the requests 😅

OK, looks like there is only a very small wording change in the submitted patch.... which we could most likely squeeze in an upcoming commit 👍

I've been super busy lately with company projects and since I've joined the port LocalizeDrupalOrg initiative 😅

But I'll do a round of tickets this evening: Let's keep moving forward with the pending issues for the 3.7 release.
Plus D12 is now available for automated tests... with some broken jobs to fix 👌

More updates in tickets coming soon.
Thanks again @ressa! 😊

dydave’s picture

This change was processed in referring issue #3471725: Remove check for user 1 in admin_toolbar_links_access_filter_filter_non_accessible_links:

Updated README.md: Removed an "a" character in a sentence.

The rest of the changes is pretty much replacing - with * which should probably be applied to all README.md doc files in the module.

We would probably need to create a ticket for that, along:
#3520700: Update the project page

Remaining tasks:

  • Create a ticket for README.md files and add an item to replace - with *.
  • Reference the created ticket in this issue and move it to completed.
ressa’s picture

Status: Active » Closed (outdated)

Thanks for taking a look at this @dydave. I think dashes are fine, and they are also used in the doc page https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or....

... so maybe we can keep the .md-files as they are?

PS. There was also #3581064: Improve README formatting: replace "eg." with "e.g." and fix capitalization which might also be done in another issue, as a small change? (I suggested to collect all small changes in one issue, and create and MR, which didn't happen ...)

In the README file, update:
"(eg. Flushing caches)"
... to:
"(e.g., flushing caches)"

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dydave’s picture

Super nice @ressa! 🤩

Thanks a lot for clarifying everything here!

I've been trying to do a bit of cleaning up in the issue queue and thought this one could also be taken out of the way.

All good here: YES definitely we could make these kinds of small changes in other issues. 👌
If there is anything else to be done with the README files we could always come back to it a bit later.

Thanks again @ressa for your great help! 🙏

ressa’s picture

Thank you @dydave for staying on top of the issue queues of the modules you maintain, I really appreciate it! And also to @sai gautam for suggesting the two (minor) improvements. I guess some credit could be given in this issue to @sai gautam? (for both suggestions) I see you already did, thanks!

It sounds great that you might be able to take of the small adjustments elsewhere, have a nice day!