Following video_embed_field #3580405, the renderEmbedCode() method is deprecated in video_embed_field 3.1.0 in favor of renderEmbed(array $options).

The Dailymotion provider plugin needs to be updated to:

  • Override renderEmbed() with the actual embed implementation (including the new loading attribute for lazy loading).
  • Deprecate renderEmbedCode() by having it delegate to $this->renderEmbed() with a @trigger_error() notice.
  • Require drupal/video_embed_field: ^3.1 in composer.json.

This follows the same deprecation pattern used in the core video_embed_field providers (YouTube, Vimeo, YouTubePlaylist).

Issue fork video_embed_dailymotion-3580429

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !5

mably’s picture

mably commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mably committed ffdb1986 on 3.x 
    task: #3580429 Deprecate renderEmbedCode() in favor of renderEmbed()

By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.