Problem/Motivation

There still existing php 8.4 deprecations over this project submodules (Even after patching the module with this issue MR : https://www.drupal.org/project/salesforce/issues/3551878 and this other MR: https://www.drupal.org/project/salesforce/issues/3547031)


  Line   modules/salesforce_push/salesforce_push.module                                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  214    Deprecated in PHP 8.4: Parameter #3 $mapped_object (Drupal\salesforce_mapping\Entity\MappedObjectInterface) is implicitly nullable via default value null.  
         🪪  parameter.implicitlyNullable                                                                                                                            
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

- run phpstan over the module code and you should see multiple violations including php 8.4 deprecations

Proposed resolution

Fix Deprecations

Issue fork salesforce-3580039

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rigoucr created an issue. See original summary.

rigoucr’s picture

rigoucr
Primary language Spanish
commented
Issue summary: View changes
rigoucr’s picture

rigoucr
Primary language Spanish
commented
Issue summary: View changes
rigoucr’s picture

rigoucr
Primary language Spanish
commented
Related issues: +#3547031: PHP 8.4 deprecation cleanup
rigoucr’s picture

rigoucr
Primary language Spanish
commented
Title: PHP 8.4 deprecations - submodules » PHP 8.4 deprecations - salesforce_push
rigoucr’s picture

rigoucr
Primary language Spanish
commented
Component: salesforce_mapping.module » Miscellaneous

rigoucr opened merge request !122

rigoucr’s picture

rigoucr
Primary language Spanish
commented
Component: Miscellaneous » salesforce_mapping.module
Status: Active » Needs review
aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Needs work

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Needs review
dieterholvoet’s picture

dieterholvoet commented
Component: salesforce_mapping.module » salesforce_push.module

aaronbauman closed merge request !122

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

This has been addressed, thanks for your patch.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.