Problem/Motivation

PHP 8.4 has new deprecations etc.

Steps to reproduce

Use php 8.4 locally, refresh a page to see deprecation warnings. Or run "phpcs -p --standard=PHPCompatibility --runtime-set testVersion 8.4"

Deprecated: Drupal\salesforce\Rest\RestException::__construct(): Implicitly marking parameter $response as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/salesforce/src/Rest/RestException.php on line 41
Deprecated: Drupal\salesforce\Rest\RestException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/salesforce/src/Rest/RestException.php on line 41

CommentFileSizeAuthor
#3 php-8.4-deprecations.patch731 bytesnehajyoti
#2 php-8.4-deprecations.patch871 bytesnehajyoti

Issue fork salesforce-3551878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehajyoti created an issue. See original summary.

nehajyoti’s picture

nehajyoti commented
StatusFileSize
new php-8.4-deprecations.patch871 bytes

adding patch file.

nehajyoti’s picture

nehajyoti commented
StatusFileSize
new php-8.4-deprecations.patch731 bytes

johnny5th made their first commit to this issue’s fork.

johnny5th’s picture

johnny5th commented

Resolved a few more implicit nullable parameters.

I also modified salesforce_push_enqueue_async to remove the default NULL parameter, as the $op parameter following it didn't also have a default.

johnny5th opened merge request !113

jaydarnell’s picture

jaydarnell
he/him
Primary language English
Location Guelph, Ontario
commented

Merge request 113 from #6 seems to take care of the deprecation warnings for PHP 8.4.

aaronbauman made their first commit to this issue’s fork.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

Merged, thanks for your work

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dipakmdhrm’s picture

dipakmdhrm commented
Status: Fixed » Active

There are still some submodules that need fix.

Please ignore.

dipakmdhrm’s picture

dipakmdhrm commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.