Support workspaces with component variants

Looks like it's introducing a hard dependency, we don't want that. How is it solved for other config entity types in Drupal core and contrib modules?

Using that handler class is not a hard dependency, if the Workspaces module is not installed the additional handler is simply not used/instantiated.

What we need to consider instead is whether these config entities should be tracked in the workspace they're being changed in. Is there an intended use case to create or edit component variants in a workspace? If so, the wse_config module (part of www.drupal.org/project/wse) needs to be used.

If not, this MR is enough.

What we need to consider instead is whether these config entities should be tracked in the workspace they're being changed in. Is there an intended use case to create or edit component variants in a workspace? If so, the wse_config module (part of www.drupal.org/project/wse) needs to be used.

As long as there are no such issues in the queue - no.

Ok, it's not a hard dependency indeed but still.. we add code specific to another module. If we continue going this way, in a year or 2 we'll have more of such third party code that accommodates something else that is completely optional, and that's not the right way to go.

I think we need a better understanding of the issue, many of other contrib modules also define config entity types (https://git.drupalcode.org/project/message/-/blob/8.x-1.x/src/Entity/Mes...), core itself defines config entity types (https://git.drupalcode.org/project/drupal/-/blob/main/core/modules/block...) and I don't see any Workspaces-specific entries in the entity type declarations.

Please do proper investigation, otherwise patching locally may be your only option if you don't have time.

There were lots of changes in the workspaces ecosystem since this Issue/PR was filed. The latest changes pushed in the PR reflect those and integrate config variants with workspace_config.

Let's give it 2 months since now, if no one will answer to #6, we can close this one with the "Nobody cares anymore" status ;)

@graber, can you please point out exactly which is the question that you want answered. Thank you.

Sure, this is my concern exactly but it's in general about adding code specific to another module here:

I think we need a better understanding of the issue, many of other contrib modules also define config entity types (https://git.drupalcode.org/project/message/-/blob/8.x-1.x/src/Entity/Mes...), core itself defines config entity types (https://git.drupalcode.org/project/drupal/-/blob/main/core/modules/block...) and I don't see any Workspaces-specific entries in the entity type declarations.

The latest MR doesn't add "code specific to another module" anymore, it implements a hook provided by the workspace_config (contrib) module. That's the designed integration point between config entities and workspaces.

Reviewed the MR, and it needs to be cleaned up a bit.

Added a few of my own. With all that handled we can land it. Thanks for reviewing and discussing on Slack @amateescu!

Ok, 1 thing can be a follow-up or optional but we need to handle https://git.drupalcode.org/project/component_variants/-/merge_requests/8...

Remaining Phpstan errors are unrelated.

In. Thanks all!