Problem/Motivation

Our interface text guidelines specify that the word "sorry" shouldn't be used in interface text: https://www.drupal.org/node/604342

Proposed resolution

Remove the word "sorry" from strings and code comments.

Issue fork drupal-3577953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dieterholvoet created an issue. See original summary.

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review

dieterholvoet opened merge request !15029

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

+1 to accept the MR.

The updated messages fully comply with Drupal’s message and UX writing guidelines, and the MR improves compliance by removing the disallowed word "Sorry".

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

We should add "sorry" to the flagWords list in .cspell.json:

    "flagWords": [
      "blacklist",
      "blacklisted",
      "e-mail",
      "grey",
      "hte",
      "illegal",
      "ist",
      "please",
      "queuing",
      "whitelist",
      "whitelisted",
      "writeable"
    ],
dcam’s picture

dcam commented
Status: Needs review » Needs work
Issue tags: +Novice

I'm setting the status to Needs Work due to comment #5.

Also, this seems like a good Novice issue.

dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

NW for fixing the test pipeline.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

These instances also need fixing:

core/modules/settings_tray/tests/modules/settings_tray_test/src/Plugin/Block/ValidationErrorBlock.php:33:44 - Forbidden word (Sorry)
core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php:287:66 - Forbidden word (Sorry)
core/modules/system/tests/modules/new_dependency_test/src/ServiceWithDependency.php:41:13 - Forbidden word (Sorry)
core/modules/system/tests/src/Functional/System/AccessDeniedTest.php:162:18 - Forbidden word (Sorry)
core/modules/system/tests/src/Functional/System/AccessDeniedTest.php:173:40 - Forbidden word (Sorry)
core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php:147:25 - Forbidden word (Sorry)
core/tests/Drupal/KernelTests/Core/KeyValueStore/DatabaseStorageExpirableTest.php:145:59 - Forbidden word (sorry)
dieterholvoet’s picture

dieterholvoet commented

I thought this was only about interface text, not tests. I'll fix the rest tomorrow.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The spell checker is the only way of preventing regressions here, and that makes no distinction as to where the word is - interface text, variable names, comments and tests are all counted the same way.

thirteenthdown made their first commit to this issue’s fork.

thirteenthdown’s picture

thirteenthdown commented
Status: Needs work » Needs review

I stepped in to help out and removed the remaining instances of "sorry" from the 7 test files identified by the spelling checker in comment #9. I have pushed the fixes to the existing MR branch (!15029). The spell-check pipeline should hopefully be clean and green now. Changing the status to Needs Review.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

The pipeline's green, this seems to fix all the issues, looks good to me.

cilefen’s picture

cilefen commented

This breaks the famous quote from the 1968 film "2001: A Space Odyssey". 😢

  • longwave committed 667a2f53 on 11.x 
    fix: #3577953 Remove "Sorry" from the codebase

By: dieterholvoet
By:...

  • longwave committed fbbb893d on main 
    fix: #3577953 Remove "Sorry" from the codebase

By: dieterholvoet
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Welcome @thirteenthdown and thank you for your contribution.

Committed and pushed fbbb893d7e4 to main and 667a2f532d0 to 11.x. Thanks!

@cilefen yeah that is a shame, these issues do sometimes feel like we sanitize too much.. but I also get why we shouldn't allow it either.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !15029

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.