Problem/Motivation

LanguageEditForm does not display a status message after saving, unlike LanguageAddForm which shows a confirmation message.

Steps to reproduce

Edit any language at /admin/config/regional/language/edit/{langcode}
Save - no status message appears

Proposed resolution

Add messenger()->addStatus() in LanguageEditForm::save().

Remaining tasks

Review and commit.

User interface changes

Status message "The language %language has been updated." shown after saving.

API changes

N/A

Data model changes

N/A

Issue fork drupal-3577711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

baikho created an issue. See original summary.

baikho changed the visibility of the branch 3577711-languageeditform-does-not to hidden.

baikho’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative, +Bug Smash Initiative
StatusFileSize
new152.21 KB

Change seems small enough don't think we need test coverage. Manually testing by editing an existing language

fixed

And I get the message.

sivaji_ganesh_jojodae’s picture

I've added comments in MR related to minor code formatting improvements.

smustgrave’s picture

FYI the formatting change introduced was unnecessary for arrays that size per the comments in the threads

longwave’s picture

Status: Reviewed & tested by the community » Needs work

Let's not make unnecessary formatting changes, fixes should be scoped as tightly as possible - there is no need to restructure the entire method here.

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Reverted the last commit.

  • larowlan committed 798fc22b on 11.x
    fix: #3577711 LanguageEditForm does not display status message after...

  • larowlan committed fe7b094e on main
    fix: #3577711 LanguageEditForm does not display status message after...
larowlan’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to main and backported to 11.x
We can't backport this to 11.3.x because there are string changes.
Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.