May we please get a CVE ID for the attached CVE file? Is is for TFA Basic Plugins.

Some notes:
• Just a reference link to the SA for now; will add links to HeroDevs and Tag1 later
• CVSS rating is just 5.1 (because admin rights are required)

Comments

aangel created an issue. See original summary.

greggles’s picture

Title: CVE ID Request for TFA Basic Plugins » CVE update request for TFA Basic Plugins
Status: Active » Needs work

That already has a CVE, though, so I think this should be a request to update the CVE to point to the herodevs and tag1 pages about it.

greggles’s picture

Title: CVE update request for TFA Basic Plugins » CVE-2025-7030 update request for TFA Basic Plugins

The CVE is CVE-2025-7030.

aangel’s picture

Sorry, I was so used to asking that question that I asked it for the wrong thing :-).

Yes, this is just an update request.

aangel’s picture

StatusFileSize
new10.58 KB

@greggles, now I remember why I wanted a different CVE: it's a different module with its own project (TFA Basic Plugins).

But that was the wrong way to go. The updated CVE simply adds a new product and mentions that the logic is subsumed in the TFA module.

Notes about this update:
• New product for TFA Basic Plugins that describe the D7 issue
• For modern Drupal, the lower bound was 0.0.0 but the earliest GA release is 1.0.0; so O set to 1.0.0 but I'm not attached to what's here (just a suggestion; in two locations)
• I've added a CVSS with a score of 5.1 that wasn't there before

cmlara’s picture

Short Version:
I would contend under CNA Operational Rules V4.1 section 4.2.13 that these are non-shared code and should receive different CVE ID's.

Based on statements given to maintainers on the TFA issue by the DST team this flaw in TFA Basic would likely not be eligible for an advisory. I would however encourage the DST team to accept section 4.1.1 (supplier determination) and override this decision.

No other review done on proposed changes to the existing CVE on the opinion that they should not share the same ID.

Background:
Parts of TFA 8.x (specifically some of the plugins and some internal logic) were sourced from the ga_login project that forked code from the TFA Basic project to create compatibility with the TFA 8.x branches. This is the share lineage between the two projects.

While the two projects share a lineage the code in TFA has become a derivative work, TFA Basic is/was not a regular upstream source. The two projects do not share a fully unified development team (though may have some developer team cross over). Large portions of the two projects (even when ignoring paths changes and whitespace changes) can not be directly patched onto each other.

CNA Operational Rules v4.1 section 4.2.13 should be evaluated
4.2.13 If multiple Products are affected by the same Independently Fixable Vulnerability, then the CNA:
Multiple products are involved. Independently fixable means a vulnerability that can be fixed without fixing a separate vulnerability. For TFA there was no other flaw that required to be fixed making it an independent vulnerability.

    MUST NOT assign more than one CVE ID if the Products are vulnerable because they share the vulnerable code. The assigned CVE ID will be shared by the vulnerable Products.
    SHOULD assign different CVE IDs if the Products do not share vulnerable code.
    SHOULD assign different CVE IDs if the CNA is uncertain whether the Products share vulnerable code.

The ga_login project significantly restructured the code however large portions were retained.
In this case patches between the two solutions are drastically different due to design changes in TFA between 7.x and 8.x. The concept is the same however the code between the two was not in shared portions of the code base. If the code was more similar I could see arguments for them possibly sharing a CVE ID, however the fork factor would still raise some questions. If there is uncertainty the preference is to assign different CVE ID's.

The Drupal Security Team deciding factor for approving CVE-2025-7030 was that the code had the following comment: // Only allow user setup access to the 'show codes' if user is self. otherwise they indicated this would have refused under the policy that any exploit requiring restrict access set to TRUE is not entitled to an advisory. This comment in code to my knowledge did not exist in TFA Basic 7.x branches. The DST would need to evaluate this policy in relation to this request and determine if they are changing their stance on supplier determination (section 4.1.1).

TFA Basic did come up during the evaluation of CVE-2025-7030 I did mention that perhaps https://www.drupal.org/project/tfa/issues/3075304 should have been raised as a security issue to TFA Basic at the time it was created. D.O. public disclosure policy certainly didn't help TFA basic to know they were at risk.

Ultimately I pushed for TFA Basic not to be considered at the time (under the DST Policy against unsupported versions) largely to avoid being bogged down in unrelated unmaintained code, the fact that its maintainer was/is a security team member, and (IIRC, however not explicitly stated in the issue itself) to avoid giving D7ES providers special treatment of disclosure of a vulnerability when no data sharing agreement with NDA's existed between them and the TFA project.

aangel’s picture

I'm not attached to using the same CVE; after all, although we have a few instances already of reusing the same CVE and just adding an additional product to the json. Here are two and I think there are more:

CVE-2025-13083 Core
CVE-2025-47705 IFrame Remove Filter

when one examines them, one sees that they had more of a direct descendent type of relationship; in some cases, the lines of code that expressed the exploit were very similar. That's not the case here; the fixes are really different in part due to Symfony's involvement.

So I'm happy to resubmit the json to be used for a unique CVE but greggles you need to agree with this way forward and issue the CVE ID first.

greggles’s picture

Title: CVE-2025-7030 update request for TFA Basic Plugins » Publish a new CVE for TFA Basic Plugins

It seems like this is the right path to publish a new CVE. I'll leave this in this status for a minute in case any disagrees with the current title and then I'll reserve a CVE for this.

aangel’s picture

@greggles possible to move forward now?

greggles’s picture

> So I'm happy to resubmit the json to be used for a unique CVE

Sounds great, please do go ahead with this.

aangel’s picture

Great...You'll recall that I need the CVE ID reserved first so that I can publish our entry and submit the CVE json with the links to the HD and Tag1 vendor advisories.

greggles’s picture

Title: Publish a new CVE for TFA Basic Plugins » Publish a new CVE for TFA Basic Plugins - CVE-2026-6816

Ah, right. Reserved CVE-2026-6816.

greggles’s picture

I looked at the file from #5 but I feel like it needs some significant changes before it can be posted so I held off on doing that myself.

@aangel hoping you can take care of that.

aangel’s picture

Status: Needs work » Needs review
StatusFileSize
new5.59 KB

Attached is a modified down entry with the following:
• date is the Tag1 publish date from last year
• product is now TFA Basic Plugins exclusively
• updated description
• severity and vector stays the same
• version boundaries stay the same
• I removed the original SA (would be confusing since it references the previous CVE) and kept the third-party advisory links.

greggles’s picture

Status: Needs review » Fixed

Thanks, aangel - now published.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.