Elasticsearch property misspelled in SynonymsSubscriber::onAlterSettings

Problem/Motivation

\Drupal\elasticsearch_connector\Event\SynonymsSubscriber::onAlterSettings has

$settings['analysis']['analyser']['querytime_synonyms'] = [
        'type' => 'custom',
        'tokenizer' => 'standard',
        'filter' => ['lowercase', 'asciifolding', 'synonyms'],
      ];

As shown in elasticsearch documentation, the setting key here should be analyzer.

Proposed resolution

Fix the spelling of the setting name.

Remaining tasks

1. Write an 9.0.x patch — merge request !178 created by @fathershawn in #2
2. Fix test — done by @mparker17 in #3
3. Review and feedback — done by @mparker17 in #4
4. RTBC and feedback — done by @mparker17 in #4
5. Commit to 9.0.x — commited by @mparker17 in #5
6. Write an 8.0.x patch — merge request !179 created by @mparker17 in #7
7. Review and feedback — skipping as it is identical to the 9.0.x branch
8. RTBC and feedback — skipping as it is identical to the 9.0.x branch
9. Commit to 8.0.x — done by @mparker17 in #9
10. Release 9.0.x — released in 9.0.0-alpha2
11. Release 8.0.x — released in 8.0.0-alpha6

User interface changes

none.

API changes

none.

Data model changes

none.