The Image cache module documentation recomends using the transliteration module and altering the theme_imagecache function. Going this way prevents a clean update of the image cache module since it is necessary to edit the file after each update.
As the altered theme_imagecache function checks the existence of the transliteration module it makes no harm to include this function by default in the image cache module.

Comments

deleuje’s picture

Good idea. I second this.

drewish’s picture

roll a patch. as it is i'm happy with just recommending this.

rbl’s picture

Hi!
The theme_imagecache function in the module looks more complex than the one on the documentation page.
Is that code up to date?

Thanks!
Ricardo

smitty’s picture

Version:6.x-2.0-beta5» 6.x-2.0-beta8
Status:Active» Needs review
StatusFileSize
new592 bytes

Here comes a patch. I've tested it only whith the 5.x-2.3 version. But it should also work with the 6.x-2.0-beta8.

thePanz’s picture

StatusFileSize
new789 bytes
kiamlaluno’s picture

+1 for the feature; as there is already a module that handles the transliteration of the strings used in Drupal, it would be better to use that module to avoid the duplication of existing code.
Then, the code to keep updated in case of bugs would be reduced.

smitty’s picture

I think, the patches #4 and #5 are identical.

kiamlaluno’s picture

Actually, they aren't; the initial offset reported is different (775,6 versus 697,6).

thePanz’s picture

@smitty: I took the edits from #4 and changed the 6.x module version, nothing more! :)

smitty’s picture

Fine! Then we have a patch for Drupal 5.x (#4) and for Drupal 6.x (#5).

drewish’s picture

thePanz’s picture

@drewish: we'll see this patch merged in next -beta10 release?

drewish’s picture

StatusFileSize
new905 bytes

i think this might be a better place to put it.

drewish’s picture

Status:Needs review» Fixed

committed to HEAD.

smitty’s picture

Will there be a rollback to 5.x?

drewish’s picture

yeah, going to fold that into the backport of #347566: Require transliteration module.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.