Problem/Motivation

StaticGenerator::getHtmlAssets provides an array of HTML link relationships that are supported when generating an array of HTML assets to export. At the moment that does not include rel="apple-touch-icon". This means that unless using tome_add_paths or subscribing to TomeStaticEvents::COLLECT_PATHS and explicitly adding apple-touch-icons they will not be exported which can lead to broken functionality and 404 errors.

Steps to reproduce

Add your apple touch icon to html.html.twig like so:

<link rel="apple-touch-icon" sizes="144x144" href="/some/path/apple-touch-icon.png">

Then generate the static site, observe that the apple icon is not exported.

Proposed resolution

Add "apple-touch-icon" to the array of relationships to add to the export array in StaticGenerator::getHtmlAssets().

Remaining tasks

Test and Review.

User interface changes

None

API changes

None

Data model changes

None

Issue fork tome-3575288

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

owenbush created an issue. See original summary.

owenbush opened merge request !38

owenbush’s picture

owenbush commented
Status: Active » Needs review

MR added.

owenbush’s picture

owenbush commented
Issue summary: View changes
owenbush’s picture

owenbush commented

Tests are failing for the MR, but they seem to be failing on all MRs and have been for months. The errors appear unrelated.

larowlan changed the visibility of the branch 3575288-add-apple-touch-icon-rel to hidden.

larowlan changed the visibility of the branch 3575288-add-apple-touch-icon-rel to active.

  • larowlan committed d5d5b664 on 8.x-1.x authored by owenbush 
    feat: #3575288 Add apple-touch-icon rel to StaticGenerator::...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Category: Task » Feature request
Status: Needs review » Fixed

Committed this thanks
I'll open an issue for failing tests in HEAD

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.