Describe your bug or feature request.

Some tests are failing with the Drupal next minor release (11.4).
CheckoutOrderTest failed as the message is changed in the UserNameConstraint
CouponValidationTest failed because of changes made to constraints in #3554746: Constraint plugins must use named arguments instead of an options array

Issue fork commerce-3574354

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tbkot created an issue. See original summary.

tbkot opened merge request !634

tbkot’s picture

tbkot commented
Status: Active » Needs review
jsacksick’s picture

jsacksick commented

Reviewed, don't really understand why overridding the message from the constructor is needed since we literally do the same for all constraints (redefine the message).
Would be great if we could get the illegal message from the constraint itself since the property is public. I believe this is cleaner than testing the Drupal version.

  • jsacksick committed c38922fe on 3.x authored by tbkot 
    fix: #3574354 Failed tests for Drupal 11.4 (11.x)

By: tbkot
By:...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tbkot opened merge request !652

tbkot opened merge request !669