Problem/Motivation

After #2932248: Provided config does not match the config after an export the system.action.redirect_delete_action contains both a regular dependency and an enforced dependency on the redirect module. Due to the former, the latter is unnecessary and superfluous.

Steps to reproduce

-

Proposed resolution

Remove the enforced dependency.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Issue fork redirect-3574279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler opened merge request !183

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review

Found this because the exported configuration does not match the state after installation (because the module dependency key should come before the enforced key), but in looking at this realized, we can drop the enforced one altogether.

  • berdir committed 16daa968 on 8.x-1.x authored by tstoeckler 
    fix: #3574279 Enforced dependency of delete action is unnecessary

By:...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

I thought that the regular definition is also needed when enforced is there as enforced is just to add dependences that can't be derived (not sure on that) but yes, this should be identified automatically as it uses a plugin by redirect.module.

FWIW, seems like a whole chunk of code could be removed in favor of generic support (\Drupal\redirect\Plugin\Action\DeleteRedirect as well as the multi-delete form), but that might also be a grey area about BC and so on. Small steps.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.