Problem/Motivation
Spun from and requires the fix from #3573011: fieldflow and jquery4 fixes for theme-gc-intranet theme.js
Major issue here, vanilla WxT 6.2.x or earlier installation.
Select the wxt library called gc intranet.
Visit the home page.
In the developer console network tab and click on the "js" filter, you won't find /libraries/theme-gc-intranet/js/theme.min.js. It is not loaded in any subsequent page even though we selected the gc intranet library and activated it.
Smoking gun, try using fieldflow, you will notice that it will not function as described. Fieldflow isn't loaded because /libraries/theme-gc-intranet/theme.min.js which has the fieldflow code is not loaded.
Steps to reproduce
Install a fresh wxt 6.2.x or 5.6.x or earlier. Go to the admin / configuration / wxt -> wxt library configuration form, select the "GC Intranet" theme, rebuild cache and visit the home page.
Use the developer console , go to the network tab, filter on js files, notice that /libraries/theme-gc-intranet/theme.min.js is not loaded, you will not see a theme.min.js file in the loaded js files.
Proposed resolution
Step 1) Merge the PR in #3573011: fieldflow and jquery4 fixes for theme-gc-intranet theme.js
Step 2) I have provided an additional PR for wxt_library ensure the jQuery4 compatible libraries/theme-gc-intranet/js/theme.min.js gets loaded.
Remaining tasks
See proposed resolution.
User interface changes
MR
API changes
Once fixed, a js library will be loaded in the scenario described.
Data model changes
N/A
| Comment | File | Size | Author |
|---|
Comments
Comment #2
joseph.olstadComment #3
joseph.olstadComment #4
joseph.olstadComment #5
joseph.olstadComment #6
joseph.olstadComment #7
joseph.olstadComment #8
joseph.olstadIgnore the patch files, go with the PR diff instead
Comment #9
joseph.olstadComment #10
joseph.olstadComment #11
smulvih2Tested the fix and it works as expected. Now theme-gc-intranet has been updated to v5.0.5 from 4.0.43.1 which was a much needed update. There were a few small CSS tweaks needed to fix footer styles which I pushed to wxt_bootstrap.