Problem/Motivation

Ok, long story short:
theme-gc-intranet needs jQuery4 fixes which I have pushed up into a PR.
https://github.com/drupalwxt/themes-cdn/pull/1
I have tested these new theme.js and theme.min.js and they are delivering fieldflow correctly however the theme-gc-intranet/js/theme.min.js is not loading, fieldflow will not work. I will open another issue for this to fix the wxt_library module to ensure that the (upgraded) libraries/theme-gc-intranet/theme.min.js gets loaded.

This PR includes jQuery 4 fixes for $.isArray as well as an updated fieldflow code taken from GCWeb 18.3.0.

Fieldflow is a wet-boew functionality that is cooked into theme-gcweb and theme-gc-intranet

Fieldflow works magnificently well in the latest gcweb 18.3.0 however with theme-gc-intranet v4.0.37.1 the fieldflow doesn't do anything at all because not only does it need jQuery 4 fixes , I discovered that when using the gc-intranet theme the theme-gc-intranet/js/theme.min.js isn't loading at all.

Documentation for fieldflow

This is an issue stub to resolve an upstream issue, we'll also need a few PRs to update our wet-boew/theme-gc-intranet in wxt_library and composer-extdeps once the upstream wet-boew/theme-gc-intranet fix is pushed in.

I have tested the latest fieldflow by patching v4.0.37.1 and updating the theme.js and theme.min.js with the necessary jQuery4 fixes and found it to work perfectly so I know that this will work.

Steps to reproduce

Install any recent release of WxT from the past 3 or 4 years however I'm testing with WxT 6.2.x with Drupal 11.2.10. Others on my team have reported this as a long standing issue.
In the admin/configuration/ wxt library form, select the wxt library option "GC Intranet". Rebuild cache, add node content with source mode in ckeditor that includes fieldflow compatible markup. Follow fieldflow instructions in the fieldflow documentation for specifics.

Dig a little further and you'll notice that theme-gc-intranet/js/theme.min.js or theme-gc-intranet/js/theme.js is not loading at all when the gc intranet theme library is enabled.

Proposed resolution

  1. Review and merge this PR for themes-cdn for our theme-cdn with jQuery4 fixes and updates to fieldflow logic.
  2. Tag v4.0.44 of the theme-gc-intranet branch for drupalwxt/themes-cdn after the above PR is merged.
  3. We then need merge the new composer-extdeps entry PR for composer-extdeps with the new tag for theme-gc-intranet
  4. Now update wxt to pull in this new library v4.0.44 instead of v4.0.43.1

I've created a child issue for ensuring that the theme-gc-intranet/js/theme.min.js or theme-gc-intranet/js/theme.js gets loaded when the gc-intranet library is active.

Remaining tasks

See the "Proposed resolution"
Resolve the library load issue #3573247: Load theme-gc-intranet/js/theme.min.js when gc intranet library is active

User interface changes

Expecting fieldflow to function as designed.

API changes

N/A

Data model changes

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

Title: fieldflow doesn't work in wet-boew/theme-gc-intranet (v4.0.43.1) » fieldflow broken in wet-boew/theme-gc-intranet (v4.0.43.1)
joseph.olstad’s picture

Ok, found out where to fix this, I'll compile fixes and push a PR into
https://github.com/drupalwxt/themes-cdn/tree/theme-gc-intranet
with all the new assets.

joseph.olstad’s picture

Title: fieldflow broken in wet-boew/theme-gc-intranet (v4.0.43.1) » fieldflow broken in theme-gc-intranet (v4.0.43.1) and jQuery 4 fixes
Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Title: fieldflow broken in theme-gc-intranet (v4.0.43.1) and jQuery 4 fixes » fieldflow not working because theme-gc-intranet js is not loaded (v4.0.43.1) and require jQuery 4 fixes
Priority: Normal » Major
joseph.olstad’s picture

Title: fieldflow not working because theme-gc-intranet js is not loaded (v4.0.43.1) and require jQuery 4 fixes » fieldflow updates and jquery4 fixes for theme-gc-intranet theme.js
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Title: fieldflow updates and jquery4 fixes for theme-gc-intranet theme.js » fieldflow and jquery4 fixes for theme-gc-intranet theme.js
Assigned: joseph.olstad » Unassigned
Status: Active » Needs review
smulvih2’s picture

Status: Needs review » Needs work

@joejoseph00 you PR has this:

```
v4.0.44:
type: drupal-library
dist:
type: tar
url: https://github.com/wet-boew/wet-boew-cdn/archive/v4.0.4.tar.gz
source:
type: git
url: https://github.com/wet-boew/wet-boew-cdn.git
reference: v4.0.44
```
I think URL should end with `v4.0.44.tar.gz` instead of `v4.0.4.tar.gz`. Please confirm and fix PR if this is the case. Thanks!

joseph.olstad’s picture

Assigned: Unassigned » smulvih2
Status: Needs work » Needs review

@smulvih2 , thanks for catching that, I've fixed the PR.

Back to the proposed resolution

joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Assigned: smulvih2 » joseph.olstad

Hmm.

smulvih2’s picture

Status: Needs review » Fixed

This is now fixed, after upgrading theme-gc-intranet from v4.0.43.1 to v5.0.5. Our jQuery4 fixes have also been included. I tested a few fieldflow examples in the GCIntranet theme and they are now working for me as expected.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.