Problem/Motivation

I am currently creating a starterkit theme which includes a .npmrc and .gitlab-ci.yml file which are needed for proper package publishing.

Even if I am ignoring them explicitly in ignore: key in NAME.starterkit.yml they get copied over when trying to generate a theme based on my starterkit theme.

ignore:
  - "/.gitlab-ci.yml"
  - "/.npmrc"

The reason for this is that in GenerateTheme.php the dotfiles are not included which needs to be added explicitly by adding ->ignoreDotFiles(FALSE) to it.

Steps to reproduce

  1. Add a .npmrc file to your starterkit theme
  2. Add .npmrc to the ignore: key in NAME.starterkit.yml file
  3. Generate your theme
  4. You will see that the generated theme has a copy of .npmrc

Proposed resolution

Include dotfiles in loadStarterKitConfig method.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3572084

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yannickoo created an issue. See original summary.

yannickoo’s picture

yannickoo
Location Berlin
commented
Related issues: +#3456699: The dotfiles are ignored when copied over in Starterkit
yannickoo’s picture

yannickoo
Location Berlin
commented
Issue summary: View changes
yannickoo’s picture

yannickoo
Location Berlin
commented
Issue summary: View changes

yannickoo opened merge request !14675

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Small comment on the MR, looks super close.

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Needs work » Needs review

Feedback has been implemented and MR can be checked again 💅

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks, the fix makes sense.

Backported to 11.3.x as an eligible bug fix.

Committed and pushed 2275ac6bd7e to main and fa09738bb27 to 11.x and 7fb11404a93 to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14675

  • longwave committed 7fb11404 on 11.3.x 
    fix: #3572084 Dotfiles cannot be ignored cia *.starterkit.yml file

By:...

  • longwave committed fa09738b on 11.x 
    fix: #3572084 Dotfiles cannot be ignored cia *.starterkit.yml file

By:...

  • longwave committed 2275ac6b on main 
    fix: #3572084 Dotfiles cannot be ignored cia *.starterkit.yml file

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.