Problem/Motivation

I'm the maintainer of Radix theme, and today I noticed that upon creating a Sub-theme for Radix, the dotfiles are not copied over, which is an essential part of the theming experience. I label this as Major since as of now, Radix is unusable, probably along with some other themes.

Steps to reproduce

Add a test .gitignore, .nvmrc, or .env.local file and test, or try the latest dev version of Radix to test the process.

Proposed resolution

Copy over everything unless told otherwise in exclude_files

Remaining tasks

User interface changes

None

API changes

Data model changes

Release notes snippet

Issue fork drupal-3456699

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

doxigo created an issue. See original summary.

doxigo’s picture

doxigo commented
Issue summary: View changes

nicoschi made their first commit to this issue’s fork.

nicoschi opened merge request !8549

nicoschi’s picture

nicoschi commented

Hi there, the merge request should solve the issue

nicoschi’s picture

nicoschi commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

MR should be against 11.x as the current development branch please

Since this is around the starterkit will need some test coverage for this bug.

Thanks.

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests

Flying in to do a test. Red/green test-only/test-with-patch seem to be doing the trick.
https://git.drupalcode.org/issue/drupal-3456699/-/pipelines/281941

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I was about to set back to needs work because I was concerned that this would result in copying .git/ directories but I'm pretty sure this is not the case because by default \Symfony\Component\Finder\Finder::__construct() ignores VCS files as a separate thing from dot files - so this fix looks great.

Committed and pushed 2853cf08ff to 11.x and 054cf7ef62 to 11.0.x and 3973d188bb to 10.4.x and 345597dc74 to 10.3.x. Thanks!

Backported to 10.3.x as a major and non bc affecting bugfix.

  • alexpott committed 345597dc on 10.3.x 
    Issue #3456699 by nicoschi, joelpittet, doxigo: The dotfiles are ignored...

  • alexpott committed 3973d188 on 10.4.x 
    Issue #3456699 by nicoschi, joelpittet, doxigo: The dotfiles are ignored...

  • alexpott committed 054cf7ef on 11.0.x 
    Issue #3456699 by nicoschi, joelpittet, doxigo: The dotfiles are ignored...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

  • alexpott committed 2853cf08 on 11.x 
    Issue #3456699 by nicoschi, joelpittet, doxigo: The dotfiles are ignored...
doxigo’s picture

doxigo commented

Thanks guys for rather a quick fix on this one

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.