Problem/Motivation

Let's try to get rid of those phpcs warnings, once and for all 🤞

Issue fork pathauto-3571880

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !114

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

There are 3 RTBC issues that resolve a subset of phpcs issues each, connected to an existing meta issue. Why start a new one?

mably’s picture

mably commented
Status: Active » Needs review
mably’s picture

mably commented

I tried to work on the original ones, but the rebases were too fastidious to process.

It was a lot quicker to do it from scratch.

These are globally pretty basic fixes, nothing fancy.

mably’s picture

mably commented
Parent issue: » #2833680: [META] Fix the errors/warnings reported by PHP_CodeSniffer
mably’s picture

mably commented
Title: phpcs fixes » Global phpcs fixes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I only checked the comment one, that only had fairly minor conflicts on the two .module files I think.

I had a quick look at the changes, I noticed some minor things such as a return void that I would just drop. There's also the large chunk of commented out code, as I think I commented in the existing issue there, I'd prefer just dropping that instead of formatting it in a weird way to make phpcs happy, it's been there forever I don't think there's any real issue with how things look now, also on other entity types. Didn't do a full review.

If we go ahead with this and close the other issue then I think we should at least make sure to credit the people who worked on those issues, as some invested quite a bit of time into my requirement there to split things up.

mably’s picture

mably commented

I have removed the commented code and the useless @return void.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks fine I think, didn't read all the docs changes too carefully, but didn't spot anything wrong.

  • mably committed 5fd51669 on 8.x-1.x 
    task: #3571880 Global phpcs fixes

By: mably
By: berdir
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.