[META] Fix the errors/warnings reported by PHP_CodeSniffer

Small change on patch!

Thanks @renatog, works fine... RTBC

Thanks, but this adds a lot of strange comments just to technically comply to the standards, can't accept that, see below.

1. +++ b/pathauto.js
   @@ -1,3 +1,8 @@
   +/**
   + * @file
   + * Name: pathauto.js.
   + */
   +
   

   this isn't very useful, an actual description would be nice.

2. +++ b/pathauto.module
   @@ -12,7 +13,9 @@
    /**
     * @file
   - * Main file for the Pathauto module, which automatically generates aliases for content.
   + * Main file for the Pathauto module.
   + *
   + * Which automatically generates aliases for content.
   

   that isn't really proper english anymore, we oculd leave out automatically instead, as generating kind of implies automatically.

3. +++ b/src/Form/PatternEditForm.php
   @@ -16,11 +16,15 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
    
      /**
   +   * Manager.
   +   *
       * @var \Drupal\pathauto\AliasTypeManager
       */
      protected $manager;
    
      /**
   +   * Entity.
   +   *
       * @var \Drupal\pathauto\PathautoPatternInterface
       */
   

   those descriptions are pretty bogus, if we do write something, we need to have an actual description that makes sense.

4. +++ b/src/Form/PatternEditForm.php
   @@ -70,7 +82,9 @@ class PatternEditForm extends EntityForm {
      /**
   -   * {@inheritDoc}
   +   * Build Form.
   +   *
   +   * {@inheritDoc}.
       */
      public function buildForm(array $form, FormStateInterface $form_state) {
   

   this is not valid.

5. +++ b/src/Form/PatternEditForm.php
   @@ -198,7 +212,9 @@ class PatternEditForm extends EntityForm {
    
      /**
   -   * {@inheritDoc}
   +   * Build Entity.
   +   *
   +   * {@inheritDoc}.
       */
      public function buildEntity(array $form, FormStateInterface $form_state) {
   

   this neither.

6. +++ b/src/Form/PatternEditForm.php
   @@ -255,7 +273,9 @@ class PatternEditForm extends EntityForm {
   -   * {@inheritDoc}
   +   * Function to save.
   +   *
   +   * {@inheritDoc}.
       */
   

   same.

7. +++ b/src/PathautoGeneratorInterface.php
   @@ -77,8 +79,8 @@ interface PathautoGeneratorInterface {
   -   *   - force: will force updating the path
   -   *   - language: the language for which to create the alias
   +   *   - Force: will force updating the path
   +   *   - language: the language for which to create the alias.
       *
   

   this change is also not correct, force is a lower-case key.

8. +++ b/src/PathautoPatternInterface.php
   @@ -41,6 +48,7 @@ interface PathautoPatternInterface extends ConfigEntityInterface {
       *
       * @return int
   +   *   Return weight.
   
   @@ -58,6 +66,7 @@ interface PathautoPatternInterface extends ConfigEntityInterface {
       *
       * @return \Drupal\Core\Plugin\Context\ContextInterface[]
   +   *   Return contexts.
   

   same for those things, it only makes sense to have a description if it's at least valid english

9. +++ b/src/PathautoPatternInterface.php
   @@ -171,10 +182,11 @@ interface PathautoPatternInterface extends ConfigEntityInterface {
       *
       * @return bool
   +   *   Return flag with type boolean.
       */
   

   this doesn't make sesne.

10. +++ b/src/PathautoWidget.php
    @@ -24,18 +24,19 @@ class PathautoWidget extends PathWidget {
         // @todo Impossible to do this in widget, use another solution
         /*
         $form['path'] += array(
    -      '#type' => 'fieldset',
    -      '#title' => $this->t('URL path settings'),
    -      '#collapsible' => TRUE,
    -      '#collapsed' => empty($form['path']['alias']),
    -      '#group' => 'additional_settings',
    -      '#attributes' => array(
    -        'class' => array('path-form'),
    -      ),
    -      '#access' => \Drupal::currentUser()->hasPermission('create url aliases') || \Drupal::currentUser()->hasPermission('administer url aliases'),
    -      '#weight' => 30,
    -      '#tree' => TRUE,
    -      '#element_validate' => array('path_form_element_validate'),
    +    '#type' => 'fieldset',
    +    '#title' => $this->t('URL path settings'),
    +    '#collapsible' => TRUE,
    +    '#collapsed' => empty($form['path']['alias']),
    +    '#group' => 'additional_settings',
    +    '#attributes' => array(
    +    'class' => array('path-form'),
    

    this change doesn't make sense, this is commented out code.

11. +++ b/src/Tests/PathautoBulkUpdateTest.php
    @@ -54,7 +56,10 @@ class PathautoBulkUpdateTest extends WebTestBase {
     
    -  function testBulkUpdate() {
    +  /**
    +   * Function testBulkUpdate().
    +   */
    +  public function testBulkUpdate() {
    

    this and more below are also bad, if we have a docblock it needs to be an actual sentence.

Continuing the work of the patch 'pathauto-codingstandards-2833680-4.patch'.

Sorry. A typo when saving the file.

I'm working on it.

I worked on Coding Standards against 8.x-1.x-dev.
I ran all the tests and everything seemed to work.

Needs review :D

The error occured in the patch is from Javascript Functional test (PathautoLocaleTest::testLanguagePatterns).

The code on 8.x-1.x contained a return statement in line #161 which prevented to run the rest of the assertions. The error occurs in line #182.

I was not able to fix that therefore I am leaving this one for someone with better understanding of the module.

I am working on this.

Hi, i founded some code standards errors, i will work on that.

phpcs fixed

i will review it

I did the review on the related code standards errors and they were fixed, but the 2 tests are still failing, so I believe it is still necessary to resolve them.

I will on that!

Merge conflicts resolved, but the test are failing.

1) Drupal\Tests\pathauto\FunctionalJavascript\PathautoLocaleTest::testLanguagePatterns
The link Add was not found on the page.
Failed asserting that an array has the key 0.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:119
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/core/tests/Drupal/Tests/UiHelperTrait.php:503
/var/www/html/modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoLocaleTest.php:176
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:703

fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-10.xml:
PHPUnit Test failed to complete; Error: PHPUnit 8.5.26 �[44m#StandWith�[0m�[43mUkraine�[0m

Testing Drupal\Tests\pathauto\Kernel\PathautoEntityWithStringIdTest

I Will work on it

Sorry, I couldn't identify the error.
as said in comment #28, tests keep failing

As requested by @Berdir I am going to split this MR to small one, and create separate issues.
I create child issue: #3411792: Fix phpcs Drupal.WhiteSpace, Squiz.WhiteSpace issues.

Fixed issue in the MR made during MR merge conflict fix.
And create second child issue #3411794: Fix phpcs Drupal.Arrays.Array issues

Now there are 5 issues, this should fix all phpcs errors:
#3411792: Fix phpcs Drupal.WhiteSpace, Squiz.WhiteSpace issues
#3411794: Fix phpcs Drupal.Arrays.Array issues
#3411804: Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics
#3411807: Fix phpcs Drupal.Files.LineLength issues
#3411808: Fix phpcs Drupal.Commenting issues

Convert this issue to Meta.
Update IS.

Add fresh phpcs report to IS.