Problem/Motivation

I have a large config export and attempt to run drush site-install on it. Internally, this will install module for module and runs all the install hooks. However, during installation, Drupal EntityResolverManager is not fully functional. For this reason, looking up URLs fails. For me, the error is

[ReflectionException]
Class "Drupal\views\Routing\ViewPageController" does not exist

Steps to reproduce

Theoretically, the steps are
1. Get my config_sync_directory
2. Download all the contrib Drupal modules
3. Run vendor/bin/drush si -y --config-dir=../config_sync_directory

Dear maintainers, please let me know if it worth the effort building a minimal example. Until I hear back, I currently don’t plan on adding the exact steps.

Proposed resolution

The exception occurs on maxlength.install line 14
Wrap the line into a try-catch block so that installation can continue.

Remaining tasks

  • ❌ Get maintainer approval for the proposed resolution
  • ❌ Implement resolution
  • ❌ Write test coverage (contact a maintainer if you need help)
  • ❌ Maintainer review via the UI
  • ❌ Maintainer Code Review #1
  • ❌ Maintainer code review #2
  • ❌ Merge into dev branch, with credit to author and participants

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3570975-2.patch804 bytesseanb

Issue fork maxlength-3570975

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gogowitsch created an issue. See original summary.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
StatusFileSize
new 3570975-2.patch804 bytes

Just ran into this as well. Not sure how much value the message adds. Maybe we can simply remove it?

joevagyok’s picture

joevagyok commented

I agree, we could remove that message completely. Can you do an MR from the patch please?

seanb opened merge request !69

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs work » Needs review

Sure, added a MR.

joevagyok’s picture

joevagyok commented

How about we skip this whole code when we are in CLI mode? So we keep the message in the UI as suggested by @Gogowitsch.

joevagyok’s picture

joevagyok commented
Status: Needs review » Reviewed & tested by the community

Thank you for the work on this!

joevagyok’s picture

joevagyok commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joevagyok committed a64e76d9 on 3.x authored by seanb 
    Issue #3570975: Do not print install message when installing from CLI.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.