Problem/Motivation

Currently, Drupal\Tests\domain_entity\Functional\DomainEntitySourceUrlsTest::testDisabledRoute is failing. Need to investigate it and fix.

Issue fork domain_entity-3570729

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vitaliyb98 created an issue. See original summary.

vitaliyb98 opened merge request !34

vitaliyb98’s picture

vitaliyb98 commented
Status: Active » Needs review
Issue tags: +LutskGCW26

1. Fixed failed test because of /web/ prefix in the URL during testing on GitLab.
Repalced:

$this->assertSame($expected, $url, 'fromUserInput enabled route rewrite');

With:

 $this->assertStringEndsWith($expected, $url, 'fromUserInput enabled route rewrite');

Which will cover such cases. (Similar approach used in core: ViewsListTest::testViewsListLimit).

2. Fixed failed test because of deprecation "Implicitly marking parameter $items as nullable is deprecated, the explicit nullable type must be used instead"

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Fixed

This one has been reviewed and committed, thanks!
Let's proceed further issues.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.