Problem/Motivation

Currently the module doesn't declare that it requires the zip extension or any core modules.

Steps to reproduce

N/A.

Proposed resolution

Add dependencies.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork zip_field_files-3568337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andyf created an issue. See original summary.

andyf opened merge request !4

andyf’s picture

andyf commented
Assigned: andyf » Unassigned
Issue summary: View changes
Status: Active » Needs review

abelpzl closed merge request !4

abelpzl reopened merge request !4

abelpzl’s picture

abelpzl
Primary language Spanish
Location Paraná, Entre Rios, Argentina
commented
Status: Needs review » Reviewed & tested by the community

Thank you again for contributing to this module :)

abelpzl’s picture

abelpzl
Primary language Spanish
Location Paraná, Entre Rios, Argentina
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

andyf’s picture

andyf commented

Thanks @abelpzl, really appreciate the speedy turn-around, nice not to have too many patches!

In case you're not aware, you can select which users should be given credit for an issue being fixed. This shows up on their profile and can be useful both to show prospective clients and to help find old issues you worked on. The documentation has more details.

abelpzl’s picture

abelpzl
Primary language Spanish
Location Paraná, Entre Rios, Argentina
commented

I didn't know the contribution record was there now.

I'm not sure how to change the confirmation message to include the issue number and credit. Should I revert the merge request and change the commit message?

Thanks :)

andyf’s picture

andyf commented

Should I revert the merge request and change the commit message?

Personally I wouldn't worry (and you're the maintainer - you get to decide the format you'd like your commit messages to take). Note that the commit message doesn't influence credit, only what you enter on the contribution record IIUC.

By the way it's typical to include yourself as the merger to the list of contributors (:

Thanks again!

abelpzl’s picture

abelpzl
Primary language Spanish
Location Paraná, Entre Rios, Argentina
commented
Status: Fixed » Closed (fixed)