Problem/Motivation

On PHP8.4

PHP Deprecated:  Drupal\dfp\Form\AdminSettings::buildForm(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/dfp/src/Form/AdminSettings.php on line 65

Issue fork dfp-3567984

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !37

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

Ready for review.

jannakha’s picture

jannakha commented
Version: 2.0.x-dev » 3.0.x-dev

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

Works in version 3.
Commited to version 2.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contributions.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • vladimiraus committed dbac54cc on 2.0.x 
    feat: #3567984 PHP8.4 compat

By: fjgarlin
By: jannakha
By: vladimiraus

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.