Problem/Motivation

At various places in the code, I notice a wrong reference:

  /**
   * The contact entity for testing.
   *
   * @var \Drupal\crm\ContactInterface
   */
  protected $contact;

should be:

 /**
   * The contact entity for testing.
   *
   * @var \Drupal\crm\Entity\ContactInterface
   */
  protected $contact;

Issue fork crm-3567485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

svendecabooter created an issue. See original summary.

svendecabooter opened merge request !169

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Active » Needs review
jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3557877: Use autowiring wherever possible to remove create() functions, +#3567396: Use class function parameter promotion to reduce boilerplate

Looks good.

I'd suggest holding this until the two linked issues are merged as merge conflicts are possible and this is the less consequential issue.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 1.0.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Status: Reviewed & tested by the community » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging CRM as a favorite on the project page to help others discover it and show your support.
  • Review the Developer Docs for accuracy and clarity.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.