Problem/Motivation

Autowiring is the future!

create() functions hard code dependencies into implementation code, and make higher levels of PHPStan unhappy.

Autowiring is already supported in many places, and support for PlugIns is coming in 11.3.

When complete, autowiring should make our codebase cleaner, easier to follow, and more maintainable.

Steps to reproduce

N/A

Proposed resolution

  • Look at changing the services.yml to use autowiring for as many services as possible.
  • ControllerBase already uses AutowireTrait, which means that most controllers can just remove the create() function with no other changes required.
  • Any classes that implement ContainerInjectionInterface can support autowiring by using the AutowireTrait. This includes forms.
  • Support for autowiring in Plugins is being added in 11.3, with 11.3.0-alpha1 released on 6th November, and a stable release targeted for December. We should consider whether to increase core_version_requirement to 11.3 to allow autowiring of plugins and whether to increase our minimum Drupal version to utilise it.
  • There have been some concerns about the performance of autowiring due to the use of reflection, but 11.3 moves some of this to the discovery phase, reducing the burden at runtime

Remaining tasks

  • Discuss whether to move to autowiring, and the timeline for doing so.
  • Consider whether to increase core_version_reequirement, and what stage in the 11.3 cycle to do so.
  • Implement autowiring wherever possible.
  • Implement autowiring.
  • Be happy.

User interface changes

None

API changes

None

Data model changes

None

Issue fork crm-3557877

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented

This seems sensible.

If the known performance issues are mostly mitigated with the release of Drupal 11.3, and with its release expected in 2025, I'm in favor of this change being made now so long as we don't increase the core_version_requirement.

For those for whom the performance implications are significant, they can upgrade to Drupal 11.3. However, I'm against requiring all potential users of CRM with existing Drupal 11.1 or 11.2 sites to upgrade their sites just to use CRM. We should keep the barrier to adopting CRM as low as possible.

I'd propose that a follow up issue be created to do this for plugins, postponed on core_version_requirement becoming >= 11.3.

lostcarpark’s picture

lostcarpark commented

Drupal 11.3 is expected in December, when 11.1 will become unsupported, so while keeping our core_version_requirement on 11.1 is fine, people should upgrade to at least 11.2 if possible.

We could consider increasing our minimum to 11.3 either in mid-2026 when 11.4 is released and 11.2 unsupported, or in December 2026 when 12 is expected to release, and the supported versions of 11 will be 11.4 and 11.5 (and all versions of D10 will be unsupported).

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented

Sounds good.

@lostcarpark, do you want to proceed with this task (excepting plugins)? If so, please assign!

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Assigned: Unassigned » jdleonard

jdleonard opened merge request !167

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Assigned: jdleonard » Unassigned
Status: Active » Needs review

I experimented with Claude Code for this and it worked quite well. Quite a bit of boilerplate reduction, reducing surface area for coding style issues, etc.

Once side effect of the related class function parameter promotion is a mix of camelCase and snake_case for class function parameters. This seems like a worthwhile tradeoff for the time being.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

Had a look at the changes and they look good to me.
Using autowiring makes the code less verbose and easier to read, so +1 from me.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 1.0.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Status: Reviewed & tested by the community » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging CRM as a favorite on the project page to help others discover it and show your support.
  • Review the Developer Docs for accuracy and clarity.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.