Problem/Motivation

Using B&M 5.1.3 on Drupal 10.6.2 & 11.3.2, both Email Settings are not saved anymore, they always are set to default site mail.

Steps to reproduce

Simply create a settings profile and set bot Email Settings option to something other than site mail and they will not be saved.

Proposed resolution

Properly set both config options in the code.

Thank you.

CommentFileSizeAuthor
#5 backup_migrate-3567236-MR64.patch1.86 KBleducdubleuet

Issue fork backup_migrate-3567236

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

leducdubleuet created an issue. See original summary.

davps made their first commit to this issue’s fork.

davps opened merge request !64

davps’s picture

davps commented
Status: Active » Needs review

Simply create a settings profile and set bot Email Settings option to something other than site mail and they will not be saved

@leducdubleuet, values ​​are saved correctly during the process. The issue is related to the editing form. The plugin's default values ​​were defined incorrectly and these default values ​​overwrite the actual value from the configuration in the editing form.

leducdubleuet’s picture

leducdubleuet commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new backup_migrate-3567236-MR64.patch1.86 KB

Sorry for the duplicate issue, I can confirm the proposed solution is working as expected, thank you very much.

I am joining the patch file "backup_migrate-3567236-MR64.patch" with the fix from the MR in case anybody needs it before the new release including it.

Thank you for your time.

anybody made their first commit to this issue’s fork.

leducdubleuet’s picture

leducdubleuet commented

Would it be possible to include this fix in the next release please?

danrod’s picture

danrod
Location Ottawa
commented

I reviewed this, I noticed that in the file src/Core/Filter/Notify.php line 71, we have a \Drupal call instead of using dependency injection:

$default_email = \Drupal::config('system.site')->get('mail');

I'll merge this for the sake of having this functionality in a tagged release soon, but I'll need to open a new issue for this.

Tested the changes and works as expected.

  • danrod committed 9d277c73 on 5.1.x authored by davps 
    Issue #3567236: Email Settings are not saved
danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.