Problem/Motivation

As noted in https://www.drupal.org/project/views_exclude_previous/issues/3564991#com... - we should have some tests!

Issue fork views_exclude_previous-3566115

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

miroslavstankov made their first commit to this issue’s fork.

miroslavstankov’s picture

miroslavstankov commented
Assigned: Unassigned » miroslavstankov

miroslavstankov opened merge request !9

miroslavstankov’s picture

miroslavstankov commented
Assigned: miroslavstankov » Unassigned
Status: Active » Needs review
ciprian.stavovei’s picture

ciprian.stavovei commented
Status: Needs review » Needs work

@miroslavstankov, thanks for the tests! They look good but the PHPCS is complaining. Could you fix those, please?

fago’s picture

fago
Primary language German
Location Vienna
commented

I added some more remarks, please check

ciprian.stavovei’s picture

ciprian.stavovei commented
Assigned: Unassigned » ciprian.stavovei

ciprian.stavovei opened merge request !10

ciprian.stavovei’s picture

ciprian.stavovei commented
Assigned: ciprian.stavovei » Unassigned
Status: Needs work » Needs review

I addressed the remarks for this PR.
P.S: There is a new PR because gitlab was not showing my commit and I thought it didn't work so I created a new one. Just merge one of them and close the other.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

Please see MR remarks

fago’s picture

fago
Primary language German
Location Vienna
commented

pipeline is not green, cspell exclusions need to be configured via gitlab-template variable

ciprian.stavovei’s picture

ciprian.stavovei commented
Status: Needs work » Needs review

PR comments addressed.

fago closed merge request !9

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.