Problem/Motivation

The \Drupal\migrate_plus\DataParserPluginManager has a syntax error for the plugin definition annotation name, there is an extra "use " instead of just the class name.

Proposed resolution

Remove the prefix.

Issue fork migrate_plus-3565462

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !147

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review

  • heddn committed b5318ae6 on 6.0.x authored by jurgenhaas 
    bug: #3565462 Syntax error in DataParserPluginManager

By: jurgenhaas
By...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for your kind fixes. Now, why didn't tests catch that?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

I guess the tests didn't pick that up because all the plugins in the module itself are using attributes, so they never need to discover plugins based on annotations. We only found that issue because that plugin manager couldn't find our plugins any longer that have not yet been updated to use attributes. The argument is supposed to be a string, and that was valid before. There just isn't a class under that string.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

That makes sense. I guess if we wanted to we could add a test module with the legacy annotation and test for that. But not its fixed, it isn't likely to happen again.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3541220: Annotation to PHP Attributes conversion

Updated to 6.0.9 today and found my @DataParser plugin stopped working, luckily thanks to test coverage.

It looks like the fix here should address my issue, can we put out a new stable 6.0.10 to ensure noone else gets caught?

Linking cause

dmundra’s picture

dmundra
he/him
Primary language English
commented

We also ran into the same issue and this change fixed it.

pookmish’s picture

pookmish commented

Yes, the fix in this issue solved an error with BC on some plugin definitions still using the annotation. Can a new release be created please?

heddn’s picture

heddn
Primary language English
Location Illinois
commented

https://www.drupal.org/project/migrate_plus/releases/6.0.10 tagged

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

Thanks for the quick release. I've updated our blog post accordingly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.