Problem/Motivation
The \Drupal\migrate_plus\DataParserPluginManager has a syntax error for the plugin definition annotation name, there is an extra "use " instead of just the class name.
Proposed resolution
Remove the prefix.
Issue fork migrate_plus-3565462
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jurgenhaasComment #5
heddnThanks for your kind fixes. Now, why didn't tests catch that?
Comment #7
jurgenhaasI guess the tests didn't pick that up because all the plugins in the module itself are using attributes, so they never need to discover plugins based on annotations. We only found that issue because that plugin manager couldn't find our plugins any longer that have not yet been updated to use attributes. The argument is supposed to be a string, and that was valid before. There just isn't a class under that string.
Comment #8
heddnThat makes sense. I guess if we wanted to we could add a test module with the legacy annotation and test for that. But not its fixed, it isn't likely to happen again.
Comment #9
dpiUpdated to 6.0.9 today and found my
@DataParserplugin stopped working, luckily thanks to test coverage.It looks like the fix here should address my issue, can we put out a new stable 6.0.10 to ensure noone else gets caught?
Linking cause
Comment #10
dmundraWe also ran into the same issue and this change fixed it.
Comment #11
pookmish commentedYes, the fix in this issue solved an error with BC on some plugin definitions still using the annotation. Can a new release be created please?
Comment #12
heddnhttps://www.drupal.org/project/migrate_plus/releases/6.0.10 tagged
Comment #13
steffenrThanks for the quick release. I've updated our blog post accordingly.