Problem/Motivation

When we created this we made a few rounds of revisions with the help text. Maybe other people want to do that too???

Proposed resolution

Make widget settings to set the help text.

Remaining tasks

If there's community desire, and a patch, then it could happen.

Issue fork metatag_simple_widget-3564801

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dalin created an issue. See original summary.

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !2

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Status: Needs review » Needs work

This is awesome!

@sourabhsisodia_
Do you want to be a co-maintainer of this module?

sourabhsisodia_’s picture

sourabhsisodia_ commented

Hii @dalin
I would love to be a co-maintainer if this module !!

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented

@sourabhsisodia_
I've never added widget settings to a module that's already been released. Do you know if we need to write an update hook or anything similar so that we don't break sites that are already using the module?

sourabhsisodia_’s picture

sourabhsisodia_ commented

Hii @dalin ,
we dont need update hook for this , as the defaultSettings() function covers this case . It will not break , i have tested it.

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Status: Needs work » Reviewed & tested by the community
dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented

GitLab appears to be intermittently down today. Feel free to merge this in, or I'll try again later.

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.