Problem/Motivation

drush updb
 --------- ------------------------ --------------- ---------------------------
  Module    Update ID                Type            Description
 --------- ------------------------ --------------- ---------------------------
  system    11202                    hook_update_n   11202 - Add an
                                                     [exit_code] column to the
                                                     {simpletest} table, if
                                                     existing.
  system    11300                    hook_update_n   11300 - Equivalent update
                                                     to 10600.
  mermaid   9002                     hook_update_n   9002 - Same as 9001 but
  _diagra                                            running a second time.
  m_field
  views     11201                    hook_update_n   11201 - Removes the
                                                     ui.show.advanced_column
                                                     setting.
  block_c   remove_block_content_l   post-update     Remove
  ontent    isting_empty                             block_content_listing_emp
                                                     ty from views.
  block_c   remove_block_content_s   post-update     Remove deprecated status
  ontent    tatus_info_keys                          and info keys from
                                                     block_content blocks.
  ckedito   list_type                post-update     No-op update that didn't
  r5                                                 update quite enough the
                                                     first time.
  ckedito   list_type_again          post-update     Updates Text Editors
  r5                                                 using CKEditor 5 to
                                                     native List "type"
                                                     functionality.
  content   add_index_content_mode   post-update     Add moderation_state
  _modera   ration_state_field_rev                   index to
  tion      ision_moderation_state                   content_moderation_state
                                                     tables.
  node      add_rebuild_permission   post-update     Grants a new permission
            _to_roles                                for rebuilding node
                                                     access permissions.
  node      create_promote_base_fi   post-update     Creates base field
            eld_overrides                            override config for the
                                                     promote base field on
                                                     node types.
  system    delete_rss_config        post-update     Delete obsolete
                                                     system.rss configuration.
  update    fix_update_emails        post-update     Remove empty email
                                                     addresses from
                                                     update.settings
                                                     configuration.
  views     add_date_default_argum   post-update     Clear cache to add new
            ents                                     date default arguments.
  views     format_plural            post-update     Updates the format plural
                                                     option for those views
                                                     using aggregation.
 --------- ------------------------ --------------- ---------------------------


 ┌ Do you wish to run the specified pending updates? ───────────┐
 │ Yes                                                          │
 └──────────────────────────────────────────────────────────────┘

>  [notice] Update started: system_update_11202
>  [notice] Update completed: system_update_11202
>  [notice] Update started: system_update_11300
>  [notice] Update completed: system_update_11300
>  [notice] Update started: mermaid_diagram_field_update_9002
>  [notice] Add allow_download column to existing field tables, again.
>  [notice] Update completed: mermaid_diagram_field_update_9002
>  [notice] Update started: views_update_11201
>  [notice] Update completed: views_update_11201
> PHP Fatal error:  Cannot redeclare non-readonly property Drupal\Component\Plugin\Attribute\AttributeBase::$dependencies as readonly Drupal\xray_audit\Attribute\XrayAuditTaskPlugin::$dependencies in /var/www/web/modules/contrib/xray_audit/src/Attribute/XrayAuditTaskPlugin.php on line 12
>  [warning] Drush command terminated abnormally.

In ProcessBase.php line 155:

  Output is empty.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork xray_audit-3564513

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

maxilein created an issue. See original summary.

maxilein’s picture

maxilein commented

Here is the order of the updates when xray is uninstalled:

>  [notice] Update started: system_update_11202
>  [notice] Update completed: system_update_11202
>  [notice] Update started: system_update_11300
>  [notice] Update completed: system_update_11300
>  [notice] Update started: mermaid_diagram_field_update_9002
>  [notice] Add allow_download column to existing field tables, again.
>  [notice] Update completed: mermaid_diagram_field_update_9002
>  [notice] Update started: views_update_11201
>  [notice] Update completed: views_update_11201
>  [notice] Update started: block_content_post_update_remove_block_content_listing_empty
>  [notice] Update completed: block_content_post_update_remove_block_content_listing_empty
>  [notice] Update started: block_content_post_update_remove_block_content_status_info_keys
>  [notice] Update completed: block_content_post_update_remove_block_content_status_info_keys
>  [notice] Update started: ckeditor5_post_update_list_type
>  [notice] Update completed: ckeditor5_post_update_list_type
>  [notice] Update started: ckeditor5_post_update_list_type_again
>  [notice] Update completed: ckeditor5_post_update_list_type_again
>  [notice] Update started: content_moderation_post_update_add_index_content_moderation_state_field_revision_moderation_state
>  [notice] Update completed: content_moderation_post_update_add_index_content_moderation_state_field_revision_moderation_state
>  [notice] Update started: node_post_update_add_rebuild_permission_to_roles
>  [notice] Update completed: node_post_update_add_rebuild_permission_to_roles
>  [notice] Update started: node_post_update_create_promote_base_field_overrides
>  [notice] Update completed: node_post_update_create_promote_base_field_overrides
>  [notice] Update started: system_post_update_delete_rss_config
>  [notice] Update completed: system_post_update_delete_rss_config
>  [notice] Update started: update_post_update_fix_update_emails
>  [notice] Update completed: update_post_update_fix_update_emails
>  [notice] Update started: views_post_update_add_date_default_arguments
>  [notice] Update completed: views_post_update_add_date_default_arguments
>  [notice] Update started: views_post_update_format_plural
>  [notice] Update completed: views_post_update_format_plural
 [success] Finished performing updates.
tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Priority: Normal » Critical

The problem is core introduced a new $dependencies property in AttributeBase in this commit:
https://git.drupalcode.org/project/drupal/-/commit/ccbcf3126e1e592d381b5...

And Xray's XrayAuditTaskPlugin, that has AttributeBase in its hierarchy, also declares a $dependencies property:
https://git.drupalcode.org/project/xray_audit/-/blob/2.x/src/Attribute/X...

This makes current Xray release not compatible with Drupal 11.3.

eduardo morales alberti made their first commit to this issue’s fork.

eduardo morales alberti opened merge request !84

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Version: 2.0.2 » 2.x-dev
eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Active » Needs review

Created MR with the required changes

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Status: Needs review » Needs work

We need to change the core requirements in info file:

From:

core_version_requirement: ^10 || ^11

To:
core_version_requirement: ^11.3

I think this implies a new major version. Also, 2.0.2 and 1.6.1 should be patched to limit the maximum 11.3 version accepted. I think this should be:

core_version_requirement: ^10 || ^11.0.0 <11.3.0

So we also need 2.0.3 and 1.6.2.

albeorte made their first commit to this issue’s fork.

albeorte’s picture

albeorte commented

I have updated the existing branch for this issue with the change requested by @tunic, updating the core requirement in the .info.yml file.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented

I think we need to create a new 3.x branch and 3 PR here:

  • Current PR (the fix) should merge to 3.x
  • A PR to merge to 2.x for the 2.0.3 release with just a change in the core requirements (limiting to <11.3)
  • A PR to merge to 1.x for the 1.6.1 release with just a change in the core requirements (limiting to <11.3)
lpeidro’s picture

lpeidro commented
Version: 2.x-dev » 3.x-dev
lpeidro’s picture

lpeidro commented
Status: Needs work » Fixed

I merge the MR.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • lpeidro committed 258a5fc6 on 3.x 
    Issue #3564513: Set dependency only with Drupal 11 in composer
tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Status: Fixed » Needs work

Reopen to fix the other branches.

tunic opened merge request !85

tunic opened merge request !86

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Status: Needs work » Fixed

Fixed 1.x and 2.x branches, releases published (2.0.3 and 1.6.2).

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.