Problem/Motivation

Yep, it's broken because of upstream changes in Symfony's validation system that are in 11.3. You have to explicitly configure constraints, you can't just hope that options land in the correct place.

It's a one-line fix, but Drupal CMS will not install at all right now on 11.3.0. It breaks with:

Error: Unknown named parameter $value in Drupal\Core\Validation\ConstraintFactory->createInstance()

This needs to be quickly fixed in Project Browser and a patch release rolled for both the 2.0.x and 2.1.x lines.

Issue fork project_browser-3563781

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !878

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » tim.plunkett
Status: Active » Needs review

Over to @tim.plunkett for the fastest commit and release in Project Browser history, probably.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Needs review » Reviewed & tested by the community

Merging next

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

The question, of course, is "Why didn't we catch this?"

I think the answer is:

  • This only got enforced, it seems, on Symfony 7.4, which is in 11.3.
  • We do test against the next minor of core, but we don't opt into strict config validation, as far as I know.

After this is merged, we are going to keep it open for tests. The tests will probably consist of opting all our existing tests into strict config validation, and fixing any failures that arise. (Core tests are opted into strict validation by default; contrib tests have to opt in explicitly, if I remember correctly. I believe there is a change record for this, I'll look for it.)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Found it: https://www.drupal.org/node/3362879

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
Status: Reviewed & tested by the community » Needs work

Self-assigning for test coverage so we can catch stuff like this.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

I assume this doesn't need to be backported to 2.0.x since this is an 11.3 bug.

If you have any guidance on how to write the test, we can do that. I'd love to get a tagged release happening with this included.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +Needs tests
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

According to the change record linked:

The above made it sound like invalid configuration would cause tests to fail. This is true only in Drupal core. For contrib/custom extensions (themes, modules, profiles), invalid configuration causes only deprecation notices, not test failures. In Drupal 11, these will become actual test failures.