doctrine/annotations is abandoned

I just upgraded my dev environment to Drupal 11..3.0 with Rules 4.0.0 installed and I have a site wide WSOD. Apache logs are telling me:

Uncaught PHP Exception Error: "Class "Doctrine\\Common\\Annotations\\AnnotationRegistry" not found" at /var/www/mysite/web/modules/contrib/rules/src/Context/AttributeDiscoveryWithAnnotations.php line 77, referer: http://mysite/admin/reports/dblog

@skwebdev: I was able to fix this with `composer require doctrine/annotations`. I know it's abandoned but why remove it if causes breakage? SMH

Connecting related issues.

@uberhacker Cheers, that fixed it.

I remove the abandoned package.

Thanks, _renify_ - worked for me, too.

I created a MR (and removed the comment line also).

Tested and verified.

Thanks for the patch @_renify_! Definitely worth tagging a new release with this patch applied along with the PHP 8.4 deprecation fixes. The current 4.0.0 "stable" release is broken. Attention maintainers!

Thanks for the patch. Works fine

Actually we should replace AnnotationRegistry class and use "Drupal\Component\Annotation\Doctrine\AnnotationRegistry"

I'm attaching the patch.

I ran into this problem while doing a Drupal 11 update.
The first indication of the problem was that I could not access admin/reports page -- WSOD

Drush WS told me this:

ID      Date           Type              Severity   Message
 ------- -------------- ----------------- ---------- -----------------------------------------------------------
  29216   22/Dec 16:30   quiz_subscriber   Warning    Caught 404 exception.
  29215   22/Dec 16:30   page not found    Warning    /app_dev.php/_profiler/open?file=app/config/config.yml
  29214   22/Dec 16:29   php               Error      Error: Class
                                                      "Doctrine\Common\Annotations\AnnotationRegistry" not
                                                      found in
                                                      Drupal\rules\Context\AttributeDiscoveryWithAnnotations->g
                                                      etDefinitions() (line 77 of /home/mysite/domains/z
  29213   22/Dec 16:29   php               Error      Error: Class
                                                      "Doctrine\Common\Annotations\AnnotationRegistry" not
                                                      found in
                                                      Drupal\rules\Context\AttributeDiscoveryWithAnnotations->g
                                                      etDefinitions() (line 77 of /home/mysite/domains/z
  29212   22/Dec 16:28   php               Error      Error: Class
                                                      "Doctrine\Common\Annotations\AnnotationRegistry" not
                                                      found in
                                                      Drupal\rules\Context\AttributeDiscoveryWithAnnotations->g
                                                      etDefinitions() (line 77 of /home/mysite/domains/z
  29211   22/Dec 16:28   php               Error      Error: Class
                                                      "Doctrine\Common\Annotations\AnnotationRegistry" not
                                                      found in
                                                      Drupal\rules\Context\AttributeDiscoveryWithAnnotations->g
                                                      etDefinitions() (line 77 of /home/mysite/domains/z
  29210   22/Dec 16:28   php               Error      Error: Class
                                                      "Doctrine\Common\Annotations\AnnotationRegistry" not
                                                      found in
                                                      Drupal\rules\Context\AttributeDiscoveryWithAnnotations->g
                                                      etDefinitions() (line 77 of /home/mysite/domains/z

I found this issue and tried to apply the patch to the non dev version of the Rules module.
Of course this not work.

So I installed the dev version and applied patch.
Everything seems OK now.

Thanks

Thanks @g_miric #15 patch worked for me.
Drupal core 10.6.1

Just a heads up that if we move ahead by adding the patch at #15 by @g_miric then we also have to update the core version required in rules.info.yml to reflect when the new package was introduced. Something like:

core_version_requirement: ^10.6 || ^11.3

@dhansen Good point.

I'm adding a new patch with core versions update in .info and composer file.

I applied patch #19 after an update to D10.6 - it worked clean - fixed. Thank you.

Patch in #19 worked for me as well. Thank you!

Adapted patch #19 for MR99.

Works for me, fix the Drupal 11.3 upgrade + no errors so far in the logs
Thanks.

Tested #19 and it worked for me.

I tested this in my development environment and it fixed the error as well. So I think it's safe to mark it RTBC.

I have resolved the errors of the current phpunit version.

Thank you! While the current MR is great, it would mean a BC break and require opening a new branch.

I think we should try to rather avoid this and address the issue by moving over to attributes, since they are supported since Drupal 10.2. See https://www.drupal.org/docs/drupal-apis/plugin-api/attribute-based-plugins

Opened #3568059: Remove annotations duplicating attributes

Think this counts as critical as this blocks 10.6/11.3

One alternative to keep coverage for both 10.5 and 10.6 would be check the version number and use the full namespace to call the annotation reset.

Can try this evening if no one beats me to it

Okay tried an approach to cover both. Tests are going to fail for 10 though

Is this getting fixed? I want to try to create a rule to unpublish nodes by content type based on a date field, but I just get the error when I try to create the condition.

thx! I discussed the issue with smustgrave on slack, we clarified we need to keep support annotations in order to not break all contrib plugins for now. Thus the last approach to conditonally use the right class based upon drupal version seems the way to go. MR seems good, thus merged! This should fix the issues with Drupal 10.6.