Problem/Motivation

Can't reuse getMediaTypes() method as it is private.
Class MediaTypeResolver can be injected in other plugins or classes but unable to use this generic method.

There is an another method for same functionality getDamMediaTypes(), so this dup needs to be removed and replaced with the getMediaTypes().

Proposed resolution

  • Change the scope of this getMediaTypes method to public and use wherever it is required.
  • Replace getDamMediaTypes() with getMediaTypes() accordingly.
  • Remove the getDamMediaTypes() method from AssetUpdater class.

Issue fork acquia_dam-3561028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankitv18 created an issue. See original summary.

ankitv18’s picture

ankitv18 commented
Parent issue: » #3561028: Scope of the getMediaTypes to be public
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue summary: View changes
ankitv18’s picture

ankitv18 commented
Parent issue: #3561028: Scope of the getMediaTypes to be public »

rajeshreeputra opened merge request !278

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Title: Scope of the getMediaTypes to be protected » Scope of the getMediaTypes to be public
Issue summary: View changes
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Assigned: Unassigned » rajeshreeputra

Rebased.

rohan-sinha made their first commit to this issue’s fork.

rohan-sinha’s picture

rohan-sinha commented
Status: Active » Needs review

rohan-sinha opened merge request !339

rohan-sinha opened merge request !340

  • rohan-sinha committed 99baea46 on 1.1.x 
    Resolve #3561028 "Fix: version typo in AssetUpdater::getDamMediaTypes()...
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Assigned: rajeshreeputra » Unassigned
Status: Needs review » Fixed

MR merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.